[GitHub] [pulsar] eolivelli commented on a diff in pull request #16590: [PIP-186] Introduce two phase deletion protocol based on system topic

2022-08-16 Thread GitBox
eolivelli commented on code in PR #16590: URL: https://github.com/apache/pulsar/pull/16590#discussion_r946919802 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java: ## @@ -1079,6 +1080,34 @@ public void deleteTopic( }); }

[GitHub] [pulsar] eolivelli commented on a diff in pull request #16590: [PIP-186] Introduce two phase deletion protocol based on system topic

2022-08-16 Thread GitBox
eolivelli commented on code in PR #16590: URL: https://github.com/apache/pulsar/pull/16590#discussion_r946912131 ## managed-ledger/src/main/java/org/apache/bookkeeper/mledger/deletion/LedgerDeletionService.java: ## @@ -0,0 +1,117 @@ +/** + * Licensed to the Apache Software Found