[GitHub] [pulsar] eolivelli commented on pull request #11293: [IO] Pass client builder to debezium database history

2021-08-10 Thread GitBox
eolivelli commented on pull request #11293: URL: https://github.com/apache/pulsar/pull/11293#issuecomment-896061700 @hangc0276 this is a new API, probably it won't be delivered in 2.8.x. I suggest to remove the 2.8.2 label. in point releases we should not add new APIs -- This is a

[GitHub] [pulsar] eolivelli commented on pull request #11293: [IO] Pass client builder to debezium database history

2021-08-09 Thread GitBox
eolivelli commented on pull request #11293: URL: https://github.com/apache/pulsar/pull/11293#issuecomment-895769447 integration tests failed, regarding Debezium, please check ``` testDebeziumMySqlSourceAvro(org.apache.pulsar.tests.integration.io.sources.debezium.PulsarDebeziumSour

[GitHub] [pulsar] eolivelli commented on pull request #11293: [IO] Pass client builder to debezium database history

2021-08-05 Thread GitBox
eolivelli commented on pull request #11293: URL: https://github.com/apache/pulsar/pull/11293#issuecomment-893624129 There are still some unaddressed comments of mine: - do not use google base64 - create a utility method to serialize/deserialize the ClientBuilder -- This is an automa