eolivelli commented on pull request #9440:
URL: https://github.com/apache/pulsar/pull/9440#issuecomment-829021833
This patch is too dangerous for 2.7.2 IMHO, I have removed the release/2.7.2
label
@codelipenghui
--
This is an automated message from the Apache Git Service.
To respond
eolivelli commented on pull request #9440:
URL: https://github.com/apache/pulsar/pull/9440#issuecomment-809118761
@merlimat can you take a final look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
eolivelli commented on pull request #9440:
URL: https://github.com/apache/pulsar/pull/9440#issuecomment-805894373
@315157973 works for me.
Let's add tests that cover all edge cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
eolivelli commented on pull request #9440:
URL: https://github.com/apache/pulsar/pull/9440#issuecomment-803401932
The constraint is that if two objects are 'equals' to each other they have
the same hash code.
--
This is an automated message from the Apache Git Service.
To respond to
eolivelli commented on pull request #9440:
URL: https://github.com/apache/pulsar/pull/9440#issuecomment-803258443
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
eolivelli commented on pull request #9440:
URL: https://github.com/apache/pulsar/pull/9440#issuecomment-802632965
Thinking out loud:
What about keeping your new tests cases, they express exactly the problem.
and fix the "equals" and "hashCode" methods of all of the implementations
