[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1177285273 ## pulsar-broker-auth-oidc/src/main/java/org/apache/pulsar/broker/authentication/oidc/AuthenticationProviderOpenID.java: ## @@ -447,7 +447,7 @@ DecodedJWT verifyJWT(P

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1176139329 ## pulsar-broker-auth-oidc/src/main/java/org/apache/pulsar/broker/authentication/oidc/AuthenticationProviderOpenID.java: ## @@ -447,7 +447,7 @@ DecodedJWT verifyJWT(P

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1176134048 ## pulsar-broker-auth-oidc/src/main/java/org/apache/pulsar/broker/authentication/oidc/AuthenticationProviderOpenID.java: ## @@ -89,7 +89,7 @@ public class Authenticat

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1176041341 ## pulsar-broker-auth-oidc/src/main/java/org/apache/pulsar/broker/authentication/oidc/AuthenticationProviderOpenID.java: ## @@ -89,7 +89,7 @@ public class Authenticat

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1176056730 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java: ## @@ -158,19 +164,18 @@ public String getAuthMethodNa

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1176041341 ## pulsar-broker-auth-oidc/src/main/java/org/apache/pulsar/broker/authentication/oidc/AuthenticationProviderOpenID.java: ## @@ -89,7 +89,7 @@ public class Authenticat

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1174918890 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/PulsarAuthenticationException.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache S

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1164506608 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/metrics/AuthenticationMetrics.java: ## @@ -43,11 +46,36 @@ public static void authentica

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1164509602 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/PulsarAuthenticationException.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache S

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1164508455 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java: ## @@ -157,8 +158,7 @@ public String authenticate(Auth

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1164506608 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/metrics/AuthenticationMetrics.java: ## @@ -43,11 +46,36 @@ public static void authentica

[GitHub] [pulsar] gaoran10 commented on a diff in pull request #20030: [fix][broker] Fix the reason label of authentication metrics

gaoran10 commented on code in PR #20030: URL: https://github.com/apache/pulsar/pull/20030#discussion_r1164506608 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/metrics/AuthenticationMetrics.java: ## @@ -43,11 +46,36 @@ public static void authentica