[GitHub] [pulsar] heronr commented on a change in pull request #4071: [Issue 2461][pulsar-client-cpp] Modified CMake files and source to enable compilation on Windows

2019-04-18 Thread GitBox
heronr commented on a change in pull request #4071: [Issue 2461][pulsar-client-cpp] Modified CMake files and source to enable compilation on Windows URL: https://github.com/apache/pulsar/pull/4071#discussion_r276912793 ## File path: pulsar-client-cpp/tests/BackoffTest.cc #

[GitHub] [pulsar] heronr commented on a change in pull request #4071: [Issue 2461][pulsar-client-cpp] Modified CMake files and source to enable compilation on Windows

2019-04-18 Thread GitBox
heronr commented on a change in pull request #4071: [Issue 2461][pulsar-client-cpp] Modified CMake files and source to enable compilation on Windows URL: https://github.com/apache/pulsar/pull/4071#discussion_r276904816 ## File path: pulsar-client-cpp/lib/ExecutorService.cc ###

[GitHub] [pulsar] heronr commented on a change in pull request #4071: [Issue 2461][pulsar-client-cpp] Modified CMake files and source to enable compilation on Windows

2019-04-18 Thread GitBox
heronr commented on a change in pull request #4071: [Issue 2461][pulsar-client-cpp] Modified CMake files and source to enable compilation on Windows URL: https://github.com/apache/pulsar/pull/4071#discussion_r276901483 ## File path: pulsar-client-cpp/lib/Backoff.cc ## @@

[GitHub] [pulsar] heronr commented on a change in pull request #4071: [Issue 2461][pulsar-client-cpp] Modified CMake files and source to enable compilation on Windows

2019-04-18 Thread GitBox
heronr commented on a change in pull request #4071: [Issue 2461][pulsar-client-cpp] Modified CMake files and source to enable compilation on Windows URL: https://github.com/apache/pulsar/pull/4071#discussion_r276897263 ## File path: pulsar-client-cpp/tests/BackoffTest.cc #