[GitHub] [pulsar] horizonzy commented on a change in pull request #11316: When delete a topic, delete the topic policy together.

2021-07-15 Thread GitBox
horizonzy commented on a change in pull request #11316: URL: https://github.com/apache/pulsar/pull/11316#discussion_r670460107 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java ## @@ -302,10 +313,27 @@ private

[GitHub] [pulsar] horizonzy commented on a change in pull request #11316: When delete a topic, delete the topic policy together.

2021-07-15 Thread GitBox
horizonzy commented on a change in pull request #11316: URL: https://github.com/apache/pulsar/pull/11316#discussion_r670445895 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -2580,6 +2581,17 @@ private boolean isSystemTopic(

[GitHub] [pulsar] horizonzy commented on a change in pull request #11316: When delete a topic, delete the topic policy together.

2021-07-15 Thread GitBox
horizonzy commented on a change in pull request #11316: URL: https://github.com/apache/pulsar/pull/11316#discussion_r670445600 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicPoliciesTest.java ## @@ -2395,4 +2395,31 @@ public void testTopicRetent

[GitHub] [pulsar] horizonzy commented on a change in pull request #11316: When delete a topic, delete the topic policy together.

2021-07-15 Thread GitBox
horizonzy commented on a change in pull request #11316: URL: https://github.com/apache/pulsar/pull/11316#discussion_r670440982 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -2580,8 +2582,19 @@ private boolean isSystemTopic(

[GitHub] [pulsar] horizonzy commented on a change in pull request #11316: When delete a topic, delete the topic policy together.

2021-07-15 Thread GitBox
horizonzy commented on a change in pull request #11316: URL: https://github.com/apache/pulsar/pull/11316#discussion_r670402938 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -2580,6 +2581,17 @@ private boolean isSystemTopic(

[GitHub] [pulsar] horizonzy commented on a change in pull request #11316: When delete a topic, delete the topic policy together.

2021-07-15 Thread GitBox
horizonzy commented on a change in pull request #11316: URL: https://github.com/apache/pulsar/pull/11316#discussion_r670400926 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -2580,8 +2582,19 @@ private boolean isSystemTopic(

[GitHub] [pulsar] horizonzy commented on a change in pull request #11316: When delete a topic, delete the topic policy together.

2021-07-14 Thread GitBox
horizonzy commented on a change in pull request #11316: URL: https://github.com/apache/pulsar/pull/11316#discussion_r670071654 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -2580,8 +2582,19 @@ private boolean isSystemTopic(

[GitHub] [pulsar] horizonzy commented on a change in pull request #11316: When delete a topic, delete the topic policy together.

2021-07-14 Thread GitBox
horizonzy commented on a change in pull request #11316: URL: https://github.com/apache/pulsar/pull/11316#discussion_r670071654 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -2580,8 +2582,19 @@ private boolean isSystemTopic(

[GitHub] [pulsar] horizonzy commented on a change in pull request #11316: When delete a topic, delete the topic policy together.

2021-07-14 Thread GitBox
horizonzy commented on a change in pull request #11316: URL: https://github.com/apache/pulsar/pull/11316#discussion_r670022996 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -2580,8 +2582,19 @@ private boolean isSystemTopic(

[GitHub] [pulsar] horizonzy commented on a change in pull request #11316: When delete a topic, delete the topic policy together.

2021-07-14 Thread GitBox
horizonzy commented on a change in pull request #11316: URL: https://github.com/apache/pulsar/pull/11316#discussion_r670022179 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ## @@ -7,7 +7,7 @@ * "License"); you may not use this