[GitHub] [pulsar] hrsakai commented on pull request #11216: [Websocket] Support cumulative acknowledge for Pulsar Websocket consumer.

2021-09-28 Thread GitBox
hrsakai commented on pull request #11216: URL: https://github.com/apache/pulsar/pull/11216#issuecomment-928415499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [pulsar] hrsakai commented on pull request #11216: [Websocket] Support cumulative acknowledge for Pulsar Websocket consumer.

2021-09-27 Thread GitBox
hrsakai commented on pull request #11216: URL: https://github.com/apache/pulsar/pull/11216#issuecomment-928418770 @rdhabalia @codelipenghui @jiazhai @tuteng @merlimat Could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [pulsar] hrsakai commented on pull request #11216: [Websocket] Support cumulative acknowledge for Pulsar Websocket consumer.

2021-09-27 Thread GitBox
hrsakai commented on pull request #11216: URL: https://github.com/apache/pulsar/pull/11216#issuecomment-928415499 I have a concern about the broker load because websocket proxy requests rest api per comulative ack. This means that if websocket proxy receives many cumulative acks, it will

[GitHub] [pulsar] hrsakai commented on pull request #11216: [Websocket] Support cumulative acknowledge for Pulsar Websocket consumer.

2021-07-15 Thread GitBox
hrsakai commented on pull request #11216: URL: https://github.com/apache/pulsar/pull/11216#issuecomment-881075664 If not pull mode, cumulative acknowledge does not seem to work well for me. * If messages are produced by java client or other clients, ws proxy can't calculate msg backlog