[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-18 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-474130208 rerun integration tests This is an automated message from the Apache

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-18 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-474110393 rerun integration tests2 This is an automated message from the Apache

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-18 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-474110332 rerun java8 tests This is an automated message from the Apache Git Se

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-16 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-473617327 rerun java8 tests This is an automated message from the Apache Git Se

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-15 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-473453206 @ivankelly you are correct service accounts are not needed to mount secrets in pods. I have remove the service account related code

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-15 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-473393406 @ivankelly responding to your comments > First of all, service accounts are not needed, you can attached the secret directly to

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-14 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-473170787 rerun java8 tests This is an automated message from the Apache Git Se

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-14 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-473125300 @ivankelly I have also added some unit tests This is an automated mes

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-14 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-473002978 @ivankelly @merlimat I have added more details on workflow of the function auth implemented in this PR. Please take a look and let me

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-11 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-471678623 @ivankelly I don't think I am assuming a token based authentication. The current implementation of the interfaces only accept token b

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-06 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-470390768 @merlimat @sijie @srkukarni @jiazhai please review. Thanks! This is

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-05 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-470005877 rerun java8 tests This is an automated message from the Apache Gi

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-05 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-469925602 rerun java8 tests rerun integration tests This is an automated mes

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-05 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-469848953 @jiazhai can you review this please? Thanks. This is an automated mes

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-469481790 rerun java8 tests rerun cpp tests This is an automated message fro

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-469440645 rerun java8 tests rerun integration tests This is an automated mes

[GitHub] [pulsar] jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions

2019-03-04 Thread GitBox
jerrypeng commented on issue #3735: Implementing authentication for Pulsar Functions URL: https://github.com/apache/pulsar/pull/3735#issuecomment-469172503 rerun java8 tests rerun integration tests rerun cpp tests This