[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469565479 @sijie yup though I am not sure setting AllowNull is producing an incompatible schema. Incompatible to what? I guess if a user wrote some co

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469565479 @sijie yup though I am not sure setting AllowNull is producing an incompatible schema. Incompatible to what? I guess if a user wrote some co

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469565479 @sijie yup though I am not sure setting AllowNull is producing an incompatible schema. Incompatible to what? I guess if a user wrote some co

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469565479 @sijie yup though I am not sure setting AllowNull is producing an incompatible schema. Incompatible to what? I guess if a user wrote some co

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469565479 @sijie yup though I am not sure setting AllowNull is producing an incompatible schema. Incompatible to what? I guess if a user wrote some co

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469565479 @sijie yup though I am not sure setting AllowNull is producing an incompatible schema. Incompatible to what? I guess if a user wrote some co

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469565479 @sijie yup though I am not sure setting AllowNull is producing an incompatible schema. Incompatible to what? I guess if a user wrote some co

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469545652 @sijie That is the workflow you were worried about right? i.e. ``` schema A => generated pojo => ReflectData.parse => schema B ```

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469545111 @sijie The User class is an Avro generated class based on the schema file. Here is the file: https://gist.github.com/jerrypeng/6bd350

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469540392 @sijie @skyrocknroll I just experimented a little. Given the schema that @skyrocknroll posted on the pulsar chat as an example: `

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469540392 @sijie @skyrocknroll I just experimented a little. Given the schema that @skyrocknroll posted on the pulsar chat as an example: `

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469518971 @sijie actually this does work: schema A => generated pojo => ReflectData.parse => schema B Schema A == . Schema B Using t

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469518971 @sijie actually this does work: schema A => generated pojo => ReflectData.parse => schema B Schema A == . Schema B Using t

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469518971 @sijie actually this does work: schema A => generated pojo => ReflectData.parse => schema B Schema A == . Schema B Using t

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469514075 @sijie that not going to work. If you take look at the java code generated by avro tools with a given schema file its going to be not what yo

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469514075 @sijie that not going to work. If you take look at the java code generated by avro tools with a given schema file its going to be not what yo

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469514075 @sijie that not going to work. If you take look at the java code generated by avro tools with a given schema file its going to be not what yo

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469488859 > The point here for a given POJO, Pulsar should maintain a basic contract: the schema generated by > Pulsar AVRO should be same/compatible wi

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469488859 > The point here for a given POJO, Pulsar should maintain a basic contract: the schema generated by > Pulsar AVRO should be same/compatible wi

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469488859 > The point here for a given POJO, Pulsar should maintain a basic contract: the schema generated by > Pulsar AVRO should be same/compatible wi

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469351952 @sijie I don't understand why you say we are not respecting the rules of AVRO, we are using the official java AVRO library to schema generatio

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469168842 @sijie I don't quite follow. If a class has a field "Integer" than the field should allow null vs if the field is "int" then it shouldn't:

[GitHub] [pulsar] jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull

2019-03-04 Thread GitBox
jerrypeng edited a comment on issue #3741: POJO AvroSchema always allowNull URL: https://github.com/apache/pulsar/issues/3741#issuecomment-469168842 @sijie I don't quite follow. If a class has a field "Integer" than the field should allow null vs if the field is "int" then it shouldn't: