[GitHub] [pulsar] linlinnn commented on pull request #10731: [function] fix update user config

2021-06-22 Thread GitBox
linlinnn commented on pull request #10731: URL: https://github.com/apache/pulsar/pull/10731#issuecomment-864790537 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] linlinnn commented on pull request #10731: [function] fix update user config

2021-06-21 Thread GitBox
linlinnn commented on pull request #10731: URL: https://github.com/apache/pulsar/pull/10731#issuecomment-864790537 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [pulsar] linlinnn commented on pull request #10731: [function] fix update user config

2021-06-20 Thread GitBox
linlinnn commented on pull request #10731: URL: https://github.com/apache/pulsar/pull/10731#issuecomment-864706035 @freeznet done, please help review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] linlinnn commented on pull request #10731: [function] fix update user config

2021-06-20 Thread GitBox
linlinnn commented on pull request #10731: URL: https://github.com/apache/pulsar/pull/10731#issuecomment-864676623 @nlu90 The previous one clear `userConfig` if no `userConfigString` provided, and this change keep the `userConfig` same as before. -- This is an automated message from the

[GitHub] [pulsar] linlinnn commented on pull request #10731: [function] fix update user config

2021-05-28 Thread GitBox
linlinnn commented on pull request #10731: URL: https://github.com/apache/pulsar/pull/10731#issuecomment-850299348 > In this way, `userConfigMap ` will be null if user does not set user config. We need to confirm if this will cause Conext.getUserConfigMap() return null. In that condition,