[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-09 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r648518432 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java ## @@ -285,6 +285,37 @@ public MarkDeleteEntry(Pos

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-09 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r648518432 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java ## @@ -285,6 +285,37 @@ public MarkDeleteEntry(Pos

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-09 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r648516867 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java ## @@ -285,6 +285,37 @@ public MarkDeleteEntry(Pos

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-08 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r648015809 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java ## @@ -177,12 +178,28 @@ public boole

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-04 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r645689015 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java ## @@ -177,12 +178,28 @@ public boole

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-04 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r645684356 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorSubscriptionTest.java ## @@ -230,6 +233,94 @@ public void testRepl

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-04 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r645684070 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java ## @@ -177,12 +178,28 @@ public boole

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-04 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r644513191 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -4035,4 +4035,126 @@ protected void inter

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-03 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r644540388 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -4035,4 +4035,134 @@ protected void inter

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-03 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r644540164 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -4035,4 +4035,126 @@ protected void inter

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-02 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r644517979 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -4035,4 +4035,134 @@ protected void inter

[GitHub] [pulsar] massakam commented on a change in pull request #10790: [broker] Add REST API to enable or disable replicated subscriptions

2021-06-02 Thread GitBox
massakam commented on a change in pull request #10790: URL: https://github.com/apache/pulsar/pull/10790#discussion_r644513191 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java ## @@ -4035,4 +4035,126 @@ protected void inter