[GitHub] [pulsar] merlimat commented on a change in pull request #11668: [Issue 11632][C++] Turning on more compiler warnings, and enforcing warnings as errors

2021-08-16 Thread GitBox
merlimat commented on a change in pull request #11668: URL: https://github.com/apache/pulsar/pull/11668#discussion_r689719433 ## File path: pulsar-client-cpp/lib/Commands.cc ## @@ -644,6 +644,7 @@ std::string Commands::messageType(BaseCommand_Type type) { return "E

[GitHub] [pulsar] merlimat commented on a change in pull request #11668: [Issue 11632][C++] Turning on more compiler warnings, and enforcing warnings as errors

2021-08-14 Thread GitBox
merlimat commented on a change in pull request #11668: URL: https://github.com/apache/pulsar/pull/11668#discussion_r689012284 ## File path: pulsar-client-cpp/lib/Commands.cc ## @@ -644,6 +644,7 @@ std::string Commands::messageType(BaseCommand_Type type) { return "E