[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-13 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r265421619 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/SchemaDefinitionBuilder.java

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-13 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r265421903 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/SchemaDefinitionBuilderImpl.java

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-13 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r264984110 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -167,25

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-12 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r264982965 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -167,25

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-12 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r264963480 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/SchemaDefinition.java ##

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-12 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r264964644 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -222,9 +245,9

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-12 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r264964829 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/SchemaDefinition.java ##

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-12 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r264963389 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/SchemaDefinition.java ##

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-12 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r264962895 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -167,25

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-12 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r264964562 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -167,25

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-12 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r264963567 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/schema/SchemaDefinition.java ##

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-06 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r263034204 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -167,49

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-06 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r263034112 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -167,49

[GitHub] [pulsar] merlimat commented on a change in pull request #3752: revise the schema default type not null

2019-03-06 Thread GitBox
merlimat commented on a change in pull request #3752: revise the schema default type not null URL: https://github.com/apache/pulsar/pull/3752#discussion_r263035591 ## File path: pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java ## @@ -167,49