merlimat commented on a change in pull request #9948:
URL: https://github.com/apache/pulsar/pull/9948#discussion_r596473130
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java
##########
@@ -99,7 +100,8 @@
@Override
public void close() throws IOException {
- // noop
+ expiredTokenMetrics.clear();
+ expiringTokenMinutesMetrics.clear();
Review comment:
The `expiredTokenMetrics` is static and therefore might be shared across
multiple instances. Calling clear on one instance close is probably not ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
