[GitHub] [pulsar] michaeljmarshall commented on pull request #9878: [Tiered Storage] Prevent Class Loader Leak; Restore Offloader Directory Override

2021-03-25 Thread GitBox
michaeljmarshall commented on pull request #9878: URL: https://github.com/apache/pulsar/pull/9878#issuecomment-807930192 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] michaeljmarshall commented on pull request #9878: [Tiered Storage] Prevent Class Loader Leak; Restore Offloader Directory Override

2021-03-24 Thread GitBox
michaeljmarshall commented on pull request #9878: URL: https://github.com/apache/pulsar/pull/9878#issuecomment-806392323 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] michaeljmarshall commented on pull request #9878: [Tiered Storage] Prevent Class Loader Leak; Restore Offloader Directory Override

2021-03-22 Thread GitBox
michaeljmarshall commented on pull request #9878: URL: https://github.com/apache/pulsar/pull/9878#issuecomment-804614255 /pulsarbot run-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [pulsar] michaeljmarshall commented on pull request #9878: [Tiered Storage] Prevent Class Loader Leak; Restore Offloader Directory Override

2021-03-17 Thread GitBox
michaeljmarshall commented on pull request #9878: URL: https://github.com/apache/pulsar/pull/9878#issuecomment-801621751 Had merge conflicts. Fixed with a rebase. This is an automated message from the Apache Git Service. To r

[GitHub] [pulsar] michaeljmarshall commented on pull request #9878: [Tiered Storage] Prevent Class Loader Leak; Restore Offloader Directory Override

2021-03-16 Thread GitBox
michaeljmarshall commented on pull request #9878: URL: https://github.com/apache/pulsar/pull/9878#issuecomment-800781010 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar] michaeljmarshall commented on pull request #9878: [Tiered Storage] Prevent Class Loader Leak; Restore Offloader Directory Override

2021-03-15 Thread GitBox
michaeljmarshall commented on pull request #9878: URL: https://github.com/apache/pulsar/pull/9878#issuecomment-799982394 Failed checkstyle. I should be able to fix it tomorrow morning. This is an automated message from the Ap

[GitHub] [pulsar] michaeljmarshall commented on pull request #9878: [Tiered Storage] Prevent Class Loader Leak; Restore Offloader Directory Override

2021-03-15 Thread GitBox
michaeljmarshall commented on pull request #9878: URL: https://github.com/apache/pulsar/pull/9878#issuecomment-799972743 In putting together the test, I noticed that the implementation would be cleaner with new class and test just that class, so I refactored the original change. @si

[GitHub] [pulsar] michaeljmarshall commented on pull request #9878: [Tiered Storage] Prevent Class Loader Leak; Restore Offloader Directory Override

2021-03-12 Thread GitBox
michaeljmarshall commented on pull request #9878: URL: https://github.com/apache/pulsar/pull/9878#issuecomment-797850790 /pulsarbot run-failure-checks This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar] michaeljmarshall commented on pull request #9878: [Tiered Storage] Prevent Class Loader Leak; Restore Offloader Directory Override

2021-03-11 Thread GitBox
michaeljmarshall commented on pull request #9878: URL: https://github.com/apache/pulsar/pull/9878#issuecomment-797261044 > Maybe we could find a way to make the same offloaders nar packages in the different directories only be loaded once. For example, in the PulsarService one Offloaders f

[GitHub] [pulsar] michaeljmarshall commented on pull request #9878: [Tiered Storage] Prevent Class Loader Leak; Restore Offloader Directory Override

2021-03-11 Thread GitBox
michaeljmarshall commented on pull request #9878: URL: https://github.com/apache/pulsar/pull/9878#issuecomment-796868189 > Users could change the offload directory in the namespace level or the topic-level through the admin API, right? Yes, the the `offloadersDirectory` can be overri

[GitHub] [pulsar] michaeljmarshall commented on pull request #9878: [Tiered Storage] Prevent Class Loader Leak; Restore Offloader Directory Override

2021-03-10 Thread GitBox
michaeljmarshall commented on pull request #9878: URL: https://github.com/apache/pulsar/pull/9878#issuecomment-796442155 Failed the check style. I'll be able to take a look and fix it in an hour. This is an automated message