[GitHub] [pulsar] nlu90 commented on a change in pull request #11263: Enhanced ElasticSearch Sink (TLS, Auth, KeyValue Schema, INSERT/UPDATE/DELETE, "_id" management, multi index support)

2021-07-20 Thread GitBox
nlu90 commented on a change in pull request #11263: URL: https://github.com/apache/pulsar/pull/11263#discussion_r672699904 ## File path: pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/JsonConverter.java ## @@ -0,0 +1,204 @@ +/** Review comment:

[GitHub] [pulsar] nlu90 commented on a change in pull request #11263: Enhanced ElasticSearch Sink (TLS, Auth, KeyValue Schema, INSERT/UPDATE/DELETE, "_id" management, multi index support)

2021-07-20 Thread GitBox
nlu90 commented on a change in pull request #11263: URL: https://github.com/apache/pulsar/pull/11263#discussion_r672699904 ## File path: pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/JsonConverter.java ## @@ -0,0 +1,204 @@ +/** Review comment:

[GitHub] [pulsar] nlu90 commented on a change in pull request #11263: Enhanced ElasticSearch Sink (TLS, Auth, KeyValue Schema, INSERT/UPDATE/DELETE, "_id" management, multi index support)

2021-07-19 Thread GitBox
nlu90 commented on a change in pull request #11263: URL: https://github.com/apache/pulsar/pull/11263#discussion_r672699904 ## File path: pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/JsonConverter.java ## @@ -0,0 +1,204 @@ +/** Review comment:

[GitHub] [pulsar] nlu90 commented on a change in pull request #11263: Enhanced ElasticSearch Sink (TLS, Auth, KeyValue Schema, INSERT/UPDATE/DELETE, "_id" management, multi index support)

2021-07-19 Thread GitBox
nlu90 commented on a change in pull request #11263: URL: https://github.com/apache/pulsar/pull/11263#discussion_r672699904 ## File path: pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/JsonConverter.java ## @@ -0,0 +1,204 @@ +/** Review comment:

[GitHub] [pulsar] nlu90 commented on a change in pull request #11263: Enhanced ElasticSearch Sink (TLS, Auth, KeyValue Schema, INSERT/UPDATE/DELETE, "_id" management, multi index support)

2021-07-15 Thread GitBox
nlu90 commented on a change in pull request #11263: URL: https://github.com/apache/pulsar/pull/11263#discussion_r670808134 ## File path: pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/JsonConverter.java ## @@ -0,0 +1,204 @@ +/** Review comment: