[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276522865 ## File path: pulsar-client-go/pulsar/c_producer.go ## @@ -212,10 +237,22 @@ func pulsarProducerSendC

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276523508 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,504 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276523569 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,504 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276370232 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct {

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276370232 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct {

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-17 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r276113655 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct {

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-16 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275660260 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct {

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-15 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275631397 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct {

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275131567 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275131343 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275131218 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275131207 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275130716 ## File path: pulsar-client-cpp/lib/c/c_ConsumerConfiguration.cc ## @@ -40,6 +40,19 @@ pulsar_consume

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275131764 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275131177 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct {

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275130847 ## File path: pulsar-client-go/pulsar/c_consumer.go ## @@ -147,7 +168,12 @@ func subscribeAsync(clien

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275131750 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275131144 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct {

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275130811 ## File path: pulsar-client-go/pulsar/c_consumer.go ## @@ -109,6 +112,24 @@ func subscribeAsync(clien

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275131221 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275131784 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275131401 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,494 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275130728 ## File path: pulsar-client-cpp/lib/c/c_ProducerConfiguration.cc ## @@ -66,6 +66,18 @@ pulsar_compres

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275131070 ## File path: pulsar-client-go/pulsar/client.go ## @@ -101,17 +101,17 @@ type ClientOptions struct {

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275130982 ## File path: pulsar-client-go/pulsar/c_producer.go ## @@ -212,10 +237,22 @@ func pulsarProducerSendC

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275130916 ## File path: pulsar-client-go/pulsar/c_producer.go ## @@ -108,6 +110,24 @@ func createProducerAsync(

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-13 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r275130889 ## File path: pulsar-client-go/pulsar/c_message.go ## @@ -97,8 +98,8 @@ func buildMessage(message Pro

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-08 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r273320217 ## File path: pulsar-client-go/pulsar/schema_test.go ## @@ -0,0 +1,502 @@ +// +// Licensed to the Apa

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-02 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r271398291 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,306 @@ +// +// Licensed to the Apache S

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-01 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r270957374 ## File path: pulsar-client-go/pulsar/binaryfreelist.go ## @@ -0,0 +1,318 @@ +// +// Licensed to the

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-01 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r270958226 ## File path: pulsar-client-go/pulsar/binaryfreelist.go ## @@ -0,0 +1,318 @@ +// +// Licensed to the

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-01 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r270956683 ## File path: pulsar-client-cpp/include/pulsar/c/producer_configuration.h ## @@ -43,6 +43,24 @@ typed

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-01 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r270956260 ## File path: go.mod ## @@ -0,0 +1 @@ +module github.com/wolfstudy/pulsar Review comment: @wolf

[GitHub] [pulsar] sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go

2019-04-01 Thread GitBox
sijie commented on a change in pull request #3904: [go schema] support go schema for pulsar-client-go URL: https://github.com/apache/pulsar/pull/3904#discussion_r270958850 ## File path: pulsar-client-go/pulsar/schema.go ## @@ -0,0 +1,298 @@ +// +// Licensed to the Apache S