[GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types

2019-04-10 Thread GitBox
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types URL: https://github.com/apache/pulsar/pull/4022#discussion_r274248555 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PrimitiveSchemaHandler.java

[GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types

2019-04-10 Thread GitBox
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types URL: https://github.com/apache/pulsar/pull/4022#discussion_r274246796 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/TopicSchema.java

[GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types

2019-04-10 Thread GitBox
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types URL: https://github.com/apache/pulsar/pull/4022#discussion_r274246664 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/TopicSchema.java

[GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types

2019-04-10 Thread GitBox
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types URL: https://github.com/apache/pulsar/pull/4022#discussion_r274253399 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/LongSchema.java ## @@

[GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types

2019-04-10 Thread GitBox
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types URL: https://github.com/apache/pulsar/pull/4022#discussion_r274244937 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/DoubleSchema.java ## @

[GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types

2019-04-10 Thread GitBox
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types URL: https://github.com/apache/pulsar/pull/4022#discussion_r274246800 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/TopicSchema.java

[GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types

2019-04-10 Thread GitBox
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types URL: https://github.com/apache/pulsar/pull/4022#discussion_r274248555 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PrimitiveSchemaHandler.java

[GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types

2019-04-10 Thread GitBox
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types URL: https://github.com/apache/pulsar/pull/4022#discussion_r274251984 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarRecordCursor.java

[GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types

2019-04-10 Thread GitBox
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types URL: https://github.com/apache/pulsar/pull/4022#discussion_r274250231 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarRecordCursor.java

[GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types

2019-04-10 Thread GitBox
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types URL: https://github.com/apache/pulsar/pull/4022#discussion_r274246558 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/TopicSchema.java

[GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types

2019-04-10 Thread GitBox
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types URL: https://github.com/apache/pulsar/pull/4022#discussion_r274244695 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/BooleanSchema.java ##

[GitHub] [pulsar] sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types

2019-04-10 Thread GitBox
sijie commented on a change in pull request #4022: Making use of builtin schemas for primitive types URL: https://github.com/apache/pulsar/pull/4022#discussion_r274247131 ## File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarMetadata.java