[GitHub] [pulsar] timmyyuan commented on a change in pull request #9961: [Build] Python-client build script use wrong path for root dir

2021-03-19 Thread GitBox
timmyyuan commented on a change in pull request #9961: URL: https://github.com/apache/pulsar/pull/9961#discussion_r598073803 ## File path: pulsar-client-cpp/docker/build-wheels.sh ## @@ -23,8 +23,8 @@ set -e BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}"

[GitHub] [pulsar] timmyyuan commented on a change in pull request #9961: [Build] Python-client build script use wrong path for root dir

2021-03-18 Thread GitBox
timmyyuan commented on a change in pull request #9961: URL: https://github.com/apache/pulsar/pull/9961#discussion_r597366868 ## File path: pulsar-client-cpp/docker/build-wheels.sh ## @@ -26,6 +26,9 @@ BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}" ROOT_DIR=

[GitHub] [pulsar] timmyyuan commented on a change in pull request #9961: [Build] Python-client build script use wrong path for root dir

2021-03-18 Thread GitBox
timmyyuan commented on a change in pull request #9961: URL: https://github.com/apache/pulsar/pull/9961#discussion_r597335499 ## File path: pulsar-client-cpp/docker/build-wheels.sh ## @@ -25,6 +25,7 @@ BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}" ROOT_DI

[GitHub] [pulsar] timmyyuan commented on a change in pull request #9961: [Build] Python-client build script use wrong path for root dir

2021-03-18 Thread GitBox
timmyyuan commented on a change in pull request #9961: URL: https://github.com/apache/pulsar/pull/9961#discussion_r597331408 ## File path: pulsar-client-cpp/docker/build-wheels.sh ## @@ -25,6 +25,7 @@ BUILD_IMAGE_NAME="${BUILD_IMAGE_NAME:-apachepulsar/pulsar-build}" ROOT_DI