[GitHub] [pulsar-client-go] WJL3333 commented on pull request #249: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-17 Thread GitBox
WJL commented on pull request #249: URL: https://github.com/apache/pulsar-client-go/pull/249#issuecomment-629815523 closed and goto https://github.com/apache/pulsar-client-go/pull/252 This is an automated message from the

[GitHub] [pulsar-client-go] WJL3333 commented on pull request #249: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-16 Thread GitBox
WJL commented on pull request #249: URL: https://github.com/apache/pulsar-client-go/pull/249#issuecomment-629684905 i'm confused about the above use case, need some guide on the real popuse of passing an context here. and where do you prefer to check the context? just before send or bo

[GitHub] [pulsar-client-go] WJL3333 commented on pull request #249: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-16 Thread GitBox
WJL commented on pull request #249: URL: https://github.com/apache/pulsar-client-go/pull/249#issuecomment-629678043 yeah, i think it should be, but when user pass different context with different sendtimeout to Send and SendAsync , this will introduce a lot of complicity. the message i