[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #248: Call pending callbacks of connection after run loop stopped (#239)

2020-05-17 Thread GitBox
cckellogg commented on a change in pull request #248: URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r426339996 ## File path: pulsar/internal/connection.go ## @@ -656,18 +662,20 @@ func (c *connection) Close() { c.log.Info("Connection closed")

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #248: Call pending callbacks of connection after run loop stopped (#239)

2020-05-16 Thread GitBox
cckellogg commented on a change in pull request #248: URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r426209719 ## File path: pulsar/internal/connection.go ## @@ -656,18 +662,20 @@ func (c *connection) Close() { c.log.Info("Connection closed")

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #248: Call pending callbacks of connection after run loop stopped (#239)

2020-05-15 Thread GitBox
cckellogg commented on a change in pull request #248: URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r426104452 ## File path: pulsar/internal/connection.go ## @@ -656,18 +662,20 @@ func (c *connection) Close() { c.log.Info("Connection closed")

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #248: Call pending callbacks of connection after run loop stopped (#239)

2020-05-14 Thread GitBox
cckellogg commented on a change in pull request #248: URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r424914320 ## File path: pulsar/internal/connection.go ## @@ -656,18 +662,20 @@ func (c *connection) Close() { c.log.Info("Connection closed")

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #248: Call pending callbacks of connection after run loop stopped (#239)

2020-05-13 Thread GitBox
cckellogg commented on a change in pull request #248: URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r424801740 ## File path: pulsar/internal/connection.go ## @@ -656,18 +662,20 @@ func (c *connection) Close() { c.log.Info("Connection closed")