subject:"\[GitHub\] \[pulsar\-client\-go\] cckellogg commented on a change in pull request #248\: Clean callbacks of connection after run loop stopped \(#239\)"

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #248: Clean callbacks of connection after run loop stopped (#239)

2020-06-09 Thread GitBox

cckellogg commented on a change in pull request #248: URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r437182165 ## File path: pulsar/internal/connection.go ## @@ -656,20 +662,14 @@ func (c *connection) Close() { c.log.Info("Connection closed")

[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request #248: Clean callbacks of connection after run loop stopped (#239)

2020-05-24 Thread GitBox

cckellogg commented on a change in pull request #248: URL: https://github.com/apache/pulsar-client-go/pull/248#discussion_r429725687 ## File path: pulsar/internal/connection.go ## @@ -656,18 +662,20 @@ func (c *connection) Close() { c.log.Info("Connection closed")