merlimat commented on a change in pull request #394:
URL: https://github.com/apache/pulsar-client-go/pull/394#discussion_r527268799
##########
File path: pulsar/producer.go
##########
@@ -76,6 +76,15 @@ type ProducerOptions struct {
// This properties will be visible in the topic stats
Properties map[string]string
+ // SendTimeout set the timeout for a message that not be acknowledged
by server since sent.
+ // Send and SendAsync returns an error after timeout.
+ // Default is 30 seconds, -1 to disable.
+ SendTimeout time.Duration
Review comment:
Shouldn't this be taken the `ctx` passed in by the application at the
moment of `Send()` ?
##########
File path: pulsar/producer.go
##########
@@ -76,6 +76,15 @@ type ProducerOptions struct {
// This properties will be visible in the topic stats
Properties map[string]string
+ // SendTimeout set the timeout for a message that not be acknowledged
by server since sent.
+ // Send and SendAsync returns an error after timeout.
+ // Default is 30 seconds, -1 to disable.
+ SendTimeout time.Duration
+
+ // BlockIfQueueFull control whether Send and SendAsync return error if
producer's message queue is full.
+ // Default is false.
+ BlockIfQueueFull bool
Review comment:
The logic should be negated here. The default should be to block if
queue full.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
