[GitHub] [pulsar-client-go] wolfstudy commented on pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-11-30 Thread GitBox
wolfstudy commented on pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#issuecomment-736160523 Will close this issue, the #394 has achieved this feature. This is an automated message from the Apache

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-10-09 Thread GitBox
wolfstudy commented on pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#issuecomment-705920708 @merlimat Can you double-check this change? It seems that this change introduces a new context object, which may conflict with the context we used before. ---

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-10-08 Thread GitBox
wolfstudy commented on pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#issuecomment-705920708 @merlimat Can you double-check this change? It seems that this change introduces a new context object, which may conflict with the context we used before. ---

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-06-11 Thread GitBox
wolfstudy commented on pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#issuecomment-642550145 Move the milestones to 0.2.0 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-06-09 Thread GitBox
wolfstudy commented on pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#issuecomment-640973066 @WJL Can you fix conflict? ping @cckellogg @merlimat PTAL again thanks. This is an automate

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #252: [Issue 242][pulsar-client-go] feature: add send timeout

2020-05-17 Thread GitBox
wolfstudy commented on pull request #252: URL: https://github.com/apache/pulsar-client-go/pull/252#issuecomment-629964211 > hi, this pr has some bad test case, i'm working on it. any suggestions?i'm new to unit test. > and i found in some case send timeout is a bit longer then expect. tr