[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1295645285 ## tests/DotPulsar.Tests/ReaderTests.cs: ## @@ -0,0 +1,229 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this fi

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1295645285 ## tests/DotPulsar.Tests/ReaderTests.cs: ## @@ -0,0 +1,229 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this fi

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1295474904 ## tests/DotPulsar.Tests/ReaderTests.cs: ## @@ -0,0 +1,229 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this fi

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1295474079 ## tests/DotPulsar.Tests/ReaderTests.cs: ## @@ -0,0 +1,229 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this fi

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1295473518 ## tests/DotPulsar.Tests/ReaderTests.cs: ## @@ -0,0 +1,229 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this fi

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1295472070 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +69,115 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1293213224 ## src/DotPulsar/Internal/Consumer.cs: ## @@ -86,140 +143,270 @@ public async ValueTask DisposeAsync() if (Interlocked.Exchange(ref _isDisposed, 1) != 0)

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1293209334 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +69,115 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1293204793 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +70,154 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288389669 ## src/DotPulsar/Internal/Reader.cs: ## @@ -72,86 +163,158 @@ public bool IsFinalState() public bool IsFinalState(ReaderState state) => _state.IsFin

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288381976 ## src/DotPulsar/Internal/Reader.cs: ## @@ -72,86 +162,158 @@ public bool IsFinalState() public bool IsFinalState(ReaderState state) => _state.IsFin

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288285383 ## tests/DotPulsar.Tests/ReaderTests.cs: ## @@ -0,0 +1,291 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this fi

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288284788 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +70,154 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288280993 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -34,13 +35,12 @@ public ConsumerTests(IntegrationFixture fixture) _fixture = fixture; } -[The

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288278719 ## src/DotPulsar/Internal/SubProducer.cs: ## @@ -201,7 +205,15 @@ private void ProcessReceipt(CommandSendReceipt sendReceipt) _sendQueue.Dequeue();

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288274985 ## src/DotPulsar/Internal/Reader.cs: ## @@ -72,86 +163,158 @@ public bool IsFinalState() public bool IsFinalState(ReaderState state) => _state.IsFin

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288274539 ## src/DotPulsar/Internal/Reader.cs: ## @@ -72,86 +163,158 @@ public bool IsFinalState() public bool IsFinalState(ReaderState state) => _state.IsFin

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288272054 ## src/DotPulsar/Internal/Reader.cs: ## @@ -72,86 +163,158 @@ public bool IsFinalState() public bool IsFinalState(ReaderState state) => _state.IsFin

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288271769 ## src/DotPulsar/Internal/Reader.cs: ## @@ -72,86 +163,158 @@ public bool IsFinalState() public bool IsFinalState(ReaderState state) => _state.IsFin

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288271118 ## src/DotPulsar/Internal/Reader.cs: ## @@ -72,86 +163,158 @@ public bool IsFinalState() public bool IsFinalState(ReaderState state) => _state.IsFin

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288269038 ## src/DotPulsar/Internal/Reader.cs: ## @@ -72,86 +163,158 @@ public bool IsFinalState() public bool IsFinalState(ReaderState state) => _state.IsFin

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288247702 ## src/DotPulsar/Internal/Reader.cs: ## @@ -72,86 +163,158 @@ public bool IsFinalState() public bool IsFinalState(ReaderState state) => _state.IsFin

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288243246 ## src/DotPulsar/Internal/Reader.cs: ## @@ -72,86 +163,158 @@ public bool IsFinalState() public bool IsFinalState(ReaderState state) => _state.IsFin

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288241548 ## src/DotPulsar/Internal/Reader.cs: ## @@ -15,49 +15,140 @@ namespace DotPulsar.Internal; using DotPulsar.Abstractions; -using DotPulsar.Exceptions; using D

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288239847 ## src/DotPulsar/Internal/Reader.cs: ## @@ -15,49 +15,140 @@ namespace DotPulsar.Internal; using DotPulsar.Abstractions; -using DotPulsar.Exceptions; using D

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288236048 ## tests/DotPulsar.Tests/ReaderTests.cs: ## @@ -0,0 +1,291 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this fi

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288235269 ## tests/DotPulsar.Tests/ReaderTests.cs: ## @@ -0,0 +1,291 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this fi

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288233785 ## tests/DotPulsar.Tests/ReaderTests.cs: ## @@ -0,0 +1,291 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this fi

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1288144252 ## tests/DotPulsar.Tests/ReaderTests.cs: ## @@ -0,0 +1,291 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this fi

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1285762235 ## tests/DotPulsar.Tests/ReaderTests.cs: ## @@ -0,0 +1,291 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this fi

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1285760456 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +71,153 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1285757046 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +71,153 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1285755360 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +71,153 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1285749400 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +71,153 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1285747302 ## CHANGELOG.md: ## @@ -18,6 +20,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Calling `await Send(...)` on a producer

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1285508873 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +71,151 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1284398885 ## tests/DotPulsar.Tests/ReaderTests.cs: ## @@ -0,0 +1,278 @@ +namespace DotPulsar.Tests; Review Comment: done -- This is an automated message from the A

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1284392202 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +71,151 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1284367756 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +71,151 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1284366994 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +71,151 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1284365085 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +71,151 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1284358060 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +71,151 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1284356794 ## tests/DotPulsar.Tests/ConsumerTests.cs: ## @@ -70,6 +71,151 @@ public async Task Messages_GivenTopicWithMessages_ShouldConsumeAll(int numberOfM consu

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1253121610 ## tests/DotPulsar.Tests/ProducerTests.cs: ## @@ -63,6 +63,10 @@ public async Task SimpleProduceConsume_WhenSendingMessagesToProducer_ThenReceive (await

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1253117834 ## src/DotPulsar/Internal/Consumer.cs: ## @@ -86,140 +133,191 @@ public async ValueTask DisposeAsync() if (Interlocked.Exchange(ref _isDisposed, 1) != 0)

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1253114094 ## src/DotPulsar/Internal/Consumer.cs: ## @@ -86,140 +133,191 @@ public async ValueTask DisposeAsync() if (Interlocked.Exchange(ref _isDisposed, 1) != 0)

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1253110913 ## src/DotPulsar/Internal/Consumer.cs: ## @@ -86,140 +133,191 @@ public async ValueTask DisposeAsync() if (Interlocked.Exchange(ref _isDisposed, 1) != 0)

[GitHub] [pulsar-dotpulsar] entvex commented on a diff in pull request #162: Partitioned topic support

entvex commented on code in PR #162: URL: https://github.com/apache/pulsar-dotpulsar/pull/162#discussion_r1253108841 ## src/DotPulsar/Internal/Consumer.cs: ## @@ -17,56 +17,103 @@ namespace DotPulsar.Internal; using DotPulsar.Abstractions; using DotPulsar.Exceptions; using Do