[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-03-02 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-468981803 run java8 tests --

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-03-02 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-468976593 run java8 tests --

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-03-01 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-468880125 @sijie @jiazhai or @cckellogg I guess this could be merged then. -

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-28 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-468490884 @jiazhai or @sijie If you feel there is anything else that should be added, let me

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-27 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-468148495 Jenkins: Integration tests seem to have some problems (related to Docker Images, I

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-27 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-468132913 Retest this please. --

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-26 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-467717718 @sijie I guess this could be merged unless you think there should be something el

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-25 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-467261601 run java 8 - unit tests --

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-25 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-467261661 Retest this please. --

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-25 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-467261515 rerun java 8 - unit tests

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-24 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-466836050 Retest this please. --

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-24 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-466807839 Actually. My thinking was that since these PRs are pretty small, we could just com

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-22 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-466553027 @sijie Do you think there should be anything else? ---

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-20 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-465864941 @sijie By the way, for this test that we are to add, how would we test it? Should

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-20 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-465668456 @sijie Ah, I see. I didn't realize that. I will add tests ASAP. -

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-19 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-465226357 In our previous discussion on the issue, I remember that ```createPartitionedTopic

[GitHub] ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation

2019-02-19 Thread GitBox
ConcurrencyPractitioner commented on issue #3625: [Issue #3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation URL: https://github.com/apache/pulsar/pull/3625#issuecomment-465223423 Hi @sijie I am slightly confused on how to create this REST endpoint. A non-partit