[GitHub] cckellogg commented on a change in pull request #2855: Secretprovider interfaces and some default implementations

2018-10-27 Thread GitBox
cckellogg commented on a change in pull request #2855: Secretprovider interfaces and some default implementations URL: https://github.com/apache/pulsar/pull/2855#discussion_r228729543 ## File path: pulsar-functions/secrets/src/main/java/org/apache/pulsar/functions/secretsproviderco

[GitHub] cckellogg commented on a change in pull request #2855: Secretprovider interfaces and some default implementations

2018-10-27 Thread GitBox
cckellogg commented on a change in pull request #2855: Secretprovider interfaces and some default implementations URL: https://github.com/apache/pulsar/pull/2855#discussion_r228729568 ## File path: pulsar-functions/secrets/src/main/java/org/apache/pulsar/functions/secretsproviderco

[GitHub] cckellogg commented on a change in pull request #2855: Secretprovider interfaces and some default implementations

2018-10-27 Thread GitBox
cckellogg commented on a change in pull request #2855: Secretprovider interfaces and some default implementations URL: https://github.com/apache/pulsar/pull/2855#discussion_r228728710 ## File path: pulsar-functions/secrets/src/main/java/org/apache/pulsar/functions/secretsproviderco

[GitHub] cckellogg commented on a change in pull request #2855: Secretprovider interfaces and some default implementations

2018-10-27 Thread GitBox
cckellogg commented on a change in pull request #2855: Secretprovider interfaces and some default implementations URL: https://github.com/apache/pulsar/pull/2855#discussion_r228718782 ## File path: pulsar-functions/secrets/src/main/java/org/apache/pulsar/functions/secretsproviderco

[GitHub] cckellogg commented on a change in pull request #2855: Secretprovider interfaces and some default implementations

2018-10-26 Thread GitBox
cckellogg commented on a change in pull request #2855: Secretprovider interfaces and some default implementations URL: https://github.com/apache/pulsar/pull/2855#discussion_r228702112 ## File path: pulsar-functions/secrets/src/main/java/org/apache/pulsar/functions/secretsproviderco