[GitHub] maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient

2018-10-24 Thread GitBox
maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient URL: https://github.com/apache/pulsar/pull/2814#discussion_r227976618 ## File path: pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc ## @@ -141,6 +141,9 @@ std::string ZTSClient::ybase64Enc

[GitHub] maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient

2018-10-24 Thread GitBox
maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient URL: https://github.com/apache/pulsar/pull/2814#discussion_r227976223 ## File path: pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc ## @@ -150,7 +153,12 @@ char *ZTSClient::base64Decode(co

[GitHub] maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient

2018-10-24 Thread GitBox
maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient URL: https://github.com/apache/pulsar/pull/2814#discussion_r227764640 ## File path: pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc ## @@ -143,14 +143,17 @@ std::string ZTSClient::ybase64E

[GitHub] maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient

2018-10-24 Thread GitBox
maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient URL: https://github.com/apache/pulsar/pull/2814#discussion_r227726219 ## File path: pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc ## @@ -143,14 +143,17 @@ std::string ZTSClient::ybase64E

[GitHub] maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient

2018-10-22 Thread GitBox
maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient URL: https://github.com/apache/pulsar/pull/2814#discussion_r226946724 ## File path: pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc ## @@ -143,7 +143,7 @@ std::string ZTSClient::ybase64Enc

[GitHub] maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient

2018-10-22 Thread GitBox
maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient URL: https://github.com/apache/pulsar/pull/2814#discussion_r226946772 ## File path: pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc ## @@ -143,7 +143,7 @@ std::string ZTSClient::ybase64Enc

[GitHub] maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient

2018-10-22 Thread GitBox
maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient URL: https://github.com/apache/pulsar/pull/2814#discussion_r226947435 ## File path: pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc ## @@ -143,7 +143,7 @@ std::string ZTSClient::ybase64Enc

[GitHub] maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient

2018-10-22 Thread GitBox
maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient URL: https://github.com/apache/pulsar/pull/2814#discussion_r226946662 ## File path: pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc ## @@ -143,7 +143,7 @@ std::string ZTSClient::ybase64Enc

[GitHub] maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient

2018-10-22 Thread GitBox
maskit commented on a change in pull request #2814: Fix memory issue in cpp ZTSClient URL: https://github.com/apache/pulsar/pull/2814#discussion_r226946881 ## File path: pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc ## @@ -143,7 +143,7 @@ std::string ZTSClient::ybase64Enc