merlimat closed pull request #3028: [state] use closeAsync to close state
storage client
URL: https://github.com/apache/pulsar/pull/3028
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
index 3a54455595..02a34a0c91 100644
---
a/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
+++
b/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
@@ -430,7 +430,11 @@ public void close() {
stateTable = null;
}
if (null != storageClient) {
- storageClient.close();
+ storageClient.closeAsync()
+ .exceptionally(cause -> {
+ log.warn("Failed to close state storage client", cause);
+ return null;
+ });
}
// once the thread quits, clean up the instance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
