[GitHub] sijie commented on issue #3252: [dev] PIP 27: Add checklist in github pull request template

2018-12-27 Thread GitBox
sijie commented on issue #3252: [dev] PIP 27: Add checklist in github pull request template URL: https://github.com/apache/pulsar/pull/3252#issuecomment-450199147 @maskit I updated the template to address your comments - add a visible checkbox for passing CI checks - add more inst

[GitHub] sijie commented on issue #3252: [dev] PIP 27: Add checklist in github pull request template

2018-12-27 Thread GitBox
sijie commented on issue #3252: [dev] PIP 27: Add checklist in github pull request template URL: https://github.com/apache/pulsar/pull/3252#issuecomment-450139202 > However, the questions in Documentation section might be confusing a little if that is the policy. The purpose of this

[GitHub] sijie commented on issue #3252: [dev] PIP 27: Add checklist in github pull request template

2018-12-26 Thread GitBox
sijie commented on issue #3252: [dev] PIP 27: Add checklist in github pull request template URL: https://github.com/apache/pulsar/pull/3252#issuecomment-449988743 > Is it correct? If yes, can you explain the intention? yes that's correct. because not every code change requires docum