[GitHub] srkukarni commented on issue #2762: Fix IdentitySerde

2018-10-10 Thread GitBox
srkukarni commented on issue #2762: Fix IdentitySerde URL: https://github.com/apache/pulsar/pull/2762#issuecomment-428748892 @jerrypeng I've added selective checks for IdentitySerDe. This kind of mimics the Java world as well as the very purpose of a default Serde. Please take a look again

[GitHub] srkukarni commented on issue #2762: Fix IdentitySerde

2018-10-10 Thread GitBox
srkukarni commented on issue #2762: Fix IdentitySerde URL: https://github.com/apache/pulsar/pull/2762#issuecomment-428709551 @jerrypeng since python does not support schema yet, the above won't be possible because during deserialization, we won't know what to transform into. --

[GitHub] srkukarni commented on issue #2762: Fix IdentitySerde

2018-10-10 Thread GitBox
srkukarni commented on issue #2762: Fix IdentitySerde URL: https://github.com/apache/pulsar/pull/2762#issuecomment-428703231 @jerrypeng Pickle format is very specific to Python. My main concern about making it default is that out of the box java and python functions will become illegible t

[GitHub] srkukarni commented on issue #2762: Fix IdentitySerde

2018-10-10 Thread GitBox
srkukarni commented on issue #2762: Fix IdentitySerde URL: https://github.com/apache/pulsar/pull/2762#issuecomment-428696117 @sijie @jerrypeng I've changed IdentitySerDe to StringSerDe to better reflect what it's role is. Please take a look again. Thanks! ---