[GitHub] srkukarni commented on issue #2826: Secrets Interface

2018-11-26 Thread GitBox
srkukarni commented on issue #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#issuecomment-441842038 Closing because this has since been subsumed by other prs This is an automated message from the Apach

[GitHub] srkukarni commented on issue #2826: Secrets Interface

2018-10-29 Thread GitBox
srkukarni commented on issue #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#issuecomment-433997503 @merlimat will close it once #2875 and a follow up example/doc change goes in This is an automated me

[GitHub] srkukarni commented on issue #2826: Secrets Interface

2018-10-26 Thread GitBox
srkukarni commented on issue #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#issuecomment-433470126 I will break the change into smaller changes and it might be best to comment on each individual pr T

[GitHub] srkukarni commented on issue #2826: Secrets Interface

2018-10-26 Thread GitBox
srkukarni commented on issue #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#issuecomment-433365590 @merlimat @cckellogg I've made the changes as requested. Please take a look again This is an automat

[GitHub] srkukarni commented on issue #2826: Secrets Interface

2018-10-23 Thread GitBox
srkukarni commented on issue #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#issuecomment-432462399 rerun integration tests This is an automated message from the Apache Git Service. To respond to the m