Re: [I] failTimeoutMessages() cannot delete outdated messages [pulsar-client-go]

2024-07-22 Thread via GitHub
nodece closed issue #1236: failTimeoutMessages() cannot delete outdated messages URL: https://github.com/apache/pulsar-client-go/issues/1236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] failTimeoutMessages() cannot delete outdated messages [pulsar-client-go]

2024-07-16 Thread via GitHub
geniusjoe commented on issue #1236: URL: https://github.com/apache/pulsar-client-go/issues/1236#issuecomment-223011 > > > @geniusjoe Could you review #1247? > > > > > > @nodece Sure. As I mentioned in #1247 review, this bugfix definitely can remove outdated messages, but can

Re: [I] failTimeoutMessages() cannot delete outdated messages [pulsar-client-go]

2024-07-15 Thread via GitHub
nodece commented on issue #1236: URL: https://github.com/apache/pulsar-client-go/issues/1236#issuecomment-2229997315 > > @geniusjoe Could you review #1247? > > @nodece Sure. As I mentioned in #1247 review, this bugfix definitely can remove outdated messages, but can this pr solve #55

Re: [I] failTimeoutMessages() cannot delete outdated messages [pulsar-client-go]

2024-07-15 Thread via GitHub
geniusjoe commented on issue #1236: URL: https://github.com/apache/pulsar-client-go/issues/1236#issuecomment-2229038098 > @geniusjoe Could you review #1247? Sure. As I mentioned in #1247, this bugfix definitely can remove outdated messages, but can this pr solve #551 concurrency issu

Re: [I] failTimeoutMessages() cannot delete outdated messages [pulsar-client-go]

2024-07-15 Thread via GitHub
nodece commented on issue #1236: URL: https://github.com/apache/pulsar-client-go/issues/1236#issuecomment-2228706013 @geniusjoe Could you review #1247? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] failTimeoutMessages() cannot delete outdated messages [pulsar-client-go]

2024-07-09 Thread via GitHub
nodece commented on issue #1236: URL: https://github.com/apache/pulsar-client-go/issues/1236#issuecomment-2218145988 There seems to be a concurrency issue here. I checked the pulsar-client-go codebase, and the data send and respond thread is different, we must use the same thread to

[I] failTimeoutMessages() cannot delete outdated messages [pulsar-client-go]

2024-07-03 Thread via GitHub
geniusjoe opened a new issue, #1236: URL: https://github.com/apache/pulsar-client-go/issues/1236 Expected behavior The `failTimeoutMessages()` timer in `pulsar/producer_partition.go` should periodically delete outdated messages in `p.pendingQueue` which are older than `p.options