Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-28 Thread via GitHub
nodece merged PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pu

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-25 Thread via GitHub
gunli commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1436059920 ## pulsar/producer_partition.go: ## @@ -51,14 +51,21 @@ const ( ) var ( - errFailAddToBatch = newError(AddToBatchFailed, "message add to batch fai

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-25 Thread via GitHub
nodece commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1436054134 ## pulsar/producer_partition.go: ## @@ -51,14 +51,21 @@ const ( ) var ( - errFailAddToBatch = newError(AddToBatchFailed, "message add to batch fa

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-25 Thread via GitHub
gunli commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1436026607 ## pulsar/producer_partition.go: ## @@ -51,14 +51,21 @@ const ( ) var ( - errFailAddToBatch = newError(AddToBatchFailed, "message add to batch fai

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-25 Thread via GitHub
gunli commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1436030119 ## pulsar/producer_partition.go: ## @@ -1080,7 +1088,7 @@ func (p *partitionProducer) updateSchema(sr *sendRequest) error { if schemaVersion == nil {

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-25 Thread via GitHub
gunli commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1436026607 ## pulsar/producer_partition.go: ## @@ -51,14 +51,21 @@ const ( ) var ( - errFailAddToBatch = newError(AddToBatchFailed, "message add to batch fai

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-24 Thread via GitHub
nodece commented on PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#issuecomment-1868814174 `fmt.Errorf("component error: %w", err)` is also a good idea to wrap the error, and it works with `errors.Is()`. `%w` introduced by Go 1.30, see https://pkg.go.dev/fmt@go1.

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-24 Thread via GitHub
nodece commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1435984544 ## pulsar/producer_partition.go: ## @@ -1080,7 +1088,7 @@ func (p *partitionProducer) updateSchema(sr *sendRequest) error { if schemaVersion == nil {

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-24 Thread via GitHub
nodece commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1435982667 ## pulsar/producer_partition.go: ## @@ -1019,18 +1026,18 @@ func (p *partitionProducer) SendAsync(ctx context.Context, msg *ProducerMessage, func (p *partit

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-24 Thread via GitHub
nodece commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1435982452 ## pulsar/producer_partition.go: ## @@ -51,14 +51,21 @@ const ( ) var ( - errFailAddToBatch = newError(AddToBatchFailed, "message add to batch fa

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-19 Thread via GitHub
gunli commented on PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#issuecomment-1863804780 @RobertIndie I have updated this PR and use "github.com/hashicorp/go-multierror" to join errors instead of errors.Join() of Go 1.20, would you PTAL at again? -- This is an auto

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-19 Thread via GitHub
gunli commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1431473226 ## Makefile: ## @@ -20,7 +20,7 @@ IMAGE_NAME = pulsar-client-go-test:latest PULSAR_VERSION ?= 2.10.3 PULSAR_IMAGE = apachepulsar/pulsar:$(PULSAR_VERSION) -GO_

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-19 Thread via GitHub
RobertIndie commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1431204862 ## Makefile: ## @@ -20,7 +20,7 @@ IMAGE_NAME = pulsar-client-go-test:latest PULSAR_VERSION ?= 2.10.3 PULSAR_IMAGE = apachepulsar/pulsar:$(PULSAR_VERSION

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-18 Thread via GitHub
gunli commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1430809479 ## Makefile: ## @@ -20,7 +20,7 @@ IMAGE_NAME = pulsar-client-go-test:latest PULSAR_VERSION ?= 2.10.3 PULSAR_IMAGE = apachepulsar/pulsar:$(PULSAR_VERSION) -GO_

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-18 Thread via GitHub
gunli commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1430809479 ## Makefile: ## @@ -20,7 +20,7 @@ IMAGE_NAME = pulsar-client-go-test:latest PULSAR_VERSION ?= 2.10.3 PULSAR_IMAGE = apachepulsar/pulsar:$(PULSAR_VERSION) -GO_

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-18 Thread via GitHub
gunli commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1430809479 ## Makefile: ## @@ -20,7 +20,7 @@ IMAGE_NAME = pulsar-client-go-test:latest PULSAR_VERSION ?= 2.10.3 PULSAR_IMAGE = apachepulsar/pulsar:$(PULSAR_VERSION) -GO_

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-18 Thread via GitHub
RobertIndie commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1429900655 ## Makefile: ## @@ -20,7 +20,7 @@ IMAGE_NAME = pulsar-client-go-test:latest PULSAR_VERSION ?= 2.10.3 PULSAR_IMAGE = apachepulsar/pulsar:$(PULSAR_VERSION

Re: [PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-18 Thread via GitHub
RobertIndie commented on code in PR #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143#discussion_r1429900655 ## Makefile: ## @@ -20,7 +20,7 @@ IMAGE_NAME = pulsar-client-go-test:latest PULSAR_VERSION ?= 2.10.3 PULSAR_IMAGE = apachepulsar/pulsar:$(PULSAR_VERSION

[PR] [Improve][Producer] normalize and export the errors [pulsar-client-go]

2023-12-15 Thread via GitHub
gunli opened a new pull request, #1143: URL: https://github.com/apache/pulsar-client-go/pull/1143 *(If this PR fixes a github issue, please add `Fixes #`.)* Fixes # *(or if this PR is one task of a github issue, please add `Master Issue: #` to link to the master issue.)