eolivelli commented on code in PR #22467:
URL: https://github.com/apache/pulsar/pull/22467#discussion_r1618310119
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/OpenTelemetryTopicStats.java:
##
@@ -0,0 +1,490 @@
+/*
+ * Licensed to the Apache Software Foundation (
asafm commented on code in PR #22467:
URL: https://github.com/apache/pulsar/pull/22467#discussion_r1614798773
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/OpenTelemetryTopicStats.java:
##
@@ -0,0 +1,490 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
merlimat merged PR #22467:
URL: https://github.com/apache/pulsar/pull/22467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.a
codecov-commenter commented on PR #22467:
URL: https://github.com/apache/pulsar/pull/22467#issuecomment-2083859981
##
[Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22467?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments
merlimat commented on PR #22467:
URL: https://github.com/apache/pulsar/pull/22467#issuecomment-2071140865
@dragosvictor I think we shouldn't worry about v1 topic names, these were
deprecated long ago we should actually start to get rid of them completely.
> The topic name, as is curre
dragosvictor commented on PR #22467:
URL: https://github.com/apache/pulsar/pull/22467#issuecomment-2071044457
> Changes look good.
>
> My only comment is that we should be using qualified names in the
attributes:
>
> > pulsar.namespace Includes the namespace portion only my
dragosvictor opened a new pull request, #22467:
URL: https://github.com/apache/pulsar/pull/22467
[PIP-264](https://github.com/apache/pulsar/blob/master/pip/pip-264.md)
### Motivation
This PR adds OpenTelemetry metrics for the topic messaging group. The aim is
to replace
