Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-29 Thread via GitHub
lhotari commented on PR #23004: URL: https://github.com/apache/pulsar/pull/23004#issuecomment-2255135819 @TakaHiR07 Cherry-picking PR 22860 fixed the issue. Thanks for the guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-29 Thread via GitHub
lhotari commented on PR #23004: URL: https://github.com/apache/pulsar/pull/23004#issuecomment-2255111865 > @lhotari The reason is pr-22860 not in branch-3.2. Do I change the test "testFinishTakeSnapshotWhenTopicLoading" in branch-3.2, or wait until cherry-pick pr-22860? Thanks for ch

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-28 Thread via GitHub
TakaHiR07 commented on PR #23004: URL: https://github.com/apache/pulsar/pull/23004#issuecomment-2255040654 > @TakaHiR07 would you mind backporting this change to branch-3.2? The PR can be applied to branch-3.2, but the test TopicDuplicationTest.testFinishTakeSnapshotWhenTopicLoading fails c

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-28 Thread via GitHub
lhotari commented on PR #23004: URL: https://github.com/apache/pulsar/pull/23004#issuecomment-2254996643 @TakaHiR07 would you mind backporting this change to branch-3.2? The PR can be applied to branch-3.2, but the test TopicDuplicationTest.testFinishTakeSnapshotWhenTopicLoading fails consi

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-05 Thread via GitHub
dao-jun merged PR #23004: URL: https://github.com/apache/pulsar/pull/23004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.ap

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-05 Thread via GitHub
codecov-commenter commented on PR #23004: URL: https://github.com/apache/pulsar/pull/23004#issuecomment-2211127484 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23004?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-04 Thread via GitHub
TakaHiR07 commented on code in PR #23004: URL: https://github.com/apache/pulsar/pull/23004#discussion_r1666176443 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java: ## @@ -529,6 +538,89 @@ public void testDisableNamespacePolicy

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-04 Thread via GitHub
TakaHiR07 commented on code in PR #23004: URL: https://github.com/apache/pulsar/pull/23004#discussion_r1666175402 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java: ## @@ -529,6 +538,88 @@ public void testDisableNamespacePolicy

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-04 Thread via GitHub
shibd commented on code in PR #23004: URL: https://github.com/apache/pulsar/pull/23004#discussion_r1666137904 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java: ## @@ -529,6 +538,88 @@ public void testDisableNamespacePolicyTake

Re: [PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-04 Thread via GitHub
BewareMyPower commented on code in PR #23004: URL: https://github.com/apache/pulsar/pull/23004#discussion_r1665659571 ## pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/TopicDuplicationTest.java: ## @@ -529,6 +538,89 @@ public void testDisableNamespacePo

[PR] [fix][broker] Fix MessageDeduplication replay timeout cause topic loading stuck [pulsar]

2024-07-04 Thread via GitHub
TakaHiR07 opened a new pull request, #23004: URL: https://github.com/apache/pulsar/pull/23004 Fixes https://github.com/apache/pulsar/issues/23003 ### Motivation As shown in the issue. fix the risk of topic loading stuck. ### Modifications 1. make takeSnapshot() as