Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

codelipenghui merged PR #22854: URL: https://github.com/apache/pulsar/pull/22854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

poorbarcode commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1668787772 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java: ## @@ -1573,4 +1548,51 @@ protected void setCurrentReceiverQueueSize(int

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

codelipenghui commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1668712267 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java: ## @@ -1573,4 +1548,51 @@ protected void setCurrentReceiverQueueSize(i

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

poorbarcode commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665801286 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java: ## @@ -585,19 +585,28 @@ private CompletableFuture> patternTopicSubscribeAsyn

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

poorbarcode commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665797519 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/LookupServiceTest.java: ## @@ -108,8 +108,8 @@ public void testGetTopicsOfGetTopicsResult(boolean isU

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

mattisonchao commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665793987 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java: ## @@ -585,19 +585,28 @@ private CompletableFuture> patternTopicSubscribeAsy

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

mattisonchao commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665793987 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java: ## @@ -585,19 +585,28 @@ private CompletableFuture> patternTopicSubscribeAsy

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

mattisonchao commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1665785500 ## pulsar-broker/src/test/java/org/apache/pulsar/client/impl/LookupServiceTest.java: ## @@ -108,8 +108,8 @@ public void testGetTopicsOfGetTopicsResult(boolean is

Re: [PR] [fix][client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

codecov-commenter commented on PR #22854: URL: https://github.com/apache/pulsar/pull/22854#issuecomment-2208505903 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22854?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [fix] [client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

poorbarcode commented on PR #22854: URL: https://github.com/apache/pulsar/pull/22854#issuecomment-2173950941 Rebased master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [fix] [client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

poorbarcode commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1643157512 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java: ## @@ -69,6 +69,31 @@ public class PatternMultiTopicsConsumerImpl

Re: [PR] [fix] [client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

poorbarcode commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1639675959 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java: ## @@ -1067,30 +1074,43 @@ private void doSubscribeTopicPartitions(Schem

Re: [PR] [fix] [client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

poorbarcode commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1639672682 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java: ## @@ -1573,4 +1541,51 @@ protected void setCurrentReceiverQueueSize(int

Re: [PR] [fix] [client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

poorbarcode commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1639672447 ## pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java: ## @@ -102,6 +102,10 @@ public static boolean isValid(String topic) { }

Re: [PR] [fix] [client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

poorbarcode commented on PR #22854: URL: https://github.com/apache/pulsar/pull/22854#issuecomment-2160140265 /pulsarbot rerun-failure-checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [fix] [client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

lhotari commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1628929247 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java: ## @@ -69,6 +69,31 @@ public class PatternMultiTopicsConsumerImpl ext

Re: [PR] [fix] [client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

lhotari commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1628923187 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java: ## @@ -1067,30 +1074,43 @@ private void doSubscribeTopicPartitions(Schema s

Re: [PR] [fix] [client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

lhotari commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1628920203 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/PatternMultiTopicsConsumerImpl.java: ## @@ -69,6 +69,31 @@ public class PatternMultiTopicsConsumerImpl ext

Re: [PR] [fix] [client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

lhotari commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1628364294 ## pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java: ## @@ -102,6 +102,10 @@ public static boolean isValid(String topic) { } }

Re: [PR] [fix] [client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

lhotari commented on code in PR #22854: URL: https://github.com/apache/pulsar/pull/22854#discussion_r1628361663 ## pulsar-client/src/main/java/org/apache/pulsar/client/impl/MultiTopicsConsumerImpl.java: ## @@ -1573,4 +1541,51 @@ protected void setCurrentReceiverQueueSize(int new

[PR] [fix] [client] Fix pattern consumer create crash if a part of partitions of a topic have been deleted [pulsar]

poorbarcode opened a new pull request, #22854: URL: https://github.com/apache/pulsar/pull/22854 ### Motivation Background **1.Regarding the API getting topics by regexp pattern, there are two implementations:*** - `List HttpLookupService.getPartitionedTopicMetadata(...)