Re: [PR] [improve][broker] Make BrokerSelectionStrategy pluggable [pulsar]

2024-04-23 Thread via GitHub
BewareMyPower merged PR #22553: URL: https://github.com/apache/pulsar/pull/22553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pul

Re: [PR] [improve][broker] Make BrokerSelectionStrategy pluggable [pulsar]

2024-04-23 Thread via GitHub
BewareMyPower commented on PR #22553: URL: https://github.com/apache/pulsar/pull/22553#issuecomment-2071585235 The test failed because the broker selection strategy of `CustomExtensibleLoadManager ` chooses the broker with the smallest **HTTP listen port**, while the test uses the `PulsarSe

Re: [PR] [improve][broker] Make BrokerSelectionStrategy pluggable [pulsar]

2024-04-22 Thread via GitHub
BewareMyPower commented on PR #22553: URL: https://github.com/apache/pulsar/pull/22553#issuecomment-2071455028 ``` Error: Failures: Error: org.apache.pulsar.broker.loadbalance.extensions.strategy.CustomBrokerSelectionStrategyTest.testSingleBrokerSelected [INFO] Run 1: PAS

[PR] [improve][broker] Make BrokerSelectionStrategy pluggable [pulsar]

2024-04-22 Thread via GitHub
BewareMyPower opened a new pull request, #22553: URL: https://github.com/apache/pulsar/pull/22553 ### Motivation When users want to extend the `ExtensibleLoadManagerImpl`, the `BrokerSelectionStrategy` cannot be customized, so users have to write much duplicated code for a customized