Re: [PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-29 Thread via GitHub
shibd merged PR #23072: URL: https://github.com/apache/pulsar/pull/23072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-29 Thread via GitHub
gaoran10 commented on code in PR #23072: URL: https://github.com/apache/pulsar/pull/23072#discussion_r1694963654 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java: ## @@ -531,14 +532,15 @@ public CompletableFuture messageAcked(CommandAck ack) {

Re: [PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-29 Thread via GitHub
shibd commented on code in PR #23072: URL: https://github.com/apache/pulsar/pull/23072#discussion_r1694947373 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java: ## @@ -531,14 +532,15 @@ public CompletableFuture messageAcked(CommandAck ack) {

Re: [PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-29 Thread via GitHub
shibd commented on code in PR #23072: URL: https://github.com/apache/pulsar/pull/23072#discussion_r1694947373 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java: ## @@ -531,14 +532,15 @@ public CompletableFuture messageAcked(CommandAck ack) {

Re: [PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-29 Thread via GitHub
gaoran10 commented on code in PR #23072: URL: https://github.com/apache/pulsar/pull/23072#discussion_r1694935489 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java: ## @@ -531,14 +532,15 @@ public CompletableFuture messageAcked(CommandAck ack) {

Re: [PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-29 Thread via GitHub
shibd commented on code in PR #23072: URL: https://github.com/apache/pulsar/pull/23072#discussion_r1694934170 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java: ## @@ -531,14 +532,15 @@ public CompletableFuture messageAcked(CommandAck ack) {

Re: [PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-29 Thread via GitHub
lhotari commented on code in PR #23072: URL: https://github.com/apache/pulsar/pull/23072#discussion_r1694749342 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java: ## @@ -531,14 +532,15 @@ public CompletableFuture messageAcked(CommandAck ack) {

Re: [PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-25 Thread via GitHub
shibd commented on code in PR #23072: URL: https://github.com/apache/pulsar/pull/23072#discussion_r1691007832 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java: ## @@ -531,14 +532,15 @@ public CompletableFuture messageAcked(CommandAck ack) {

Re: [PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-24 Thread via GitHub
gaoran10 commented on code in PR #23072: URL: https://github.com/apache/pulsar/pull/23072#discussion_r1690830218 ## pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java: ## @@ -531,14 +532,15 @@ public CompletableFuture messageAcked(CommandAck ack) {

Re: [PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-24 Thread via GitHub
codecov-commenter commented on PR #23072: URL: https://github.com/apache/pulsar/pull/23072#issuecomment-2248244409 ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/23072?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

[PR] [improve][broker] Optimize the performance of individual acknowledgments [pulsar]

2024-07-24 Thread via GitHub
shibd opened a new pull request, #23072: URL: https://github.com/apache/pulsar/pull/23072 ### Motivation If a subscription has many consumers and each consumer individually acknowledges messages from other consumers, this scenario is very CPU resource-intensive. Refer this: