mattisonchao closed pull request #21463: [improve][broker] Refactor method
BrokerService#unloadServiceUnit
URL: https://github.com/apache/pulsar/pull/21463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mattisonchao commented on code in PR #21463:
URL: https://github.com/apache/pulsar/pull/21463#discussion_r1376119785
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##
@@ -2189,70 +2188,53 @@ public CompletableFuture
checkTopicNsOwnership(fin
AnonHxy commented on code in PR #21463:
URL: https://github.com/apache/pulsar/pull/21463#discussion_r1375692002
##
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##
@@ -2189,70 +2188,53 @@ public CompletableFuture
checkTopicNsOwnership(final St
mattisonchao closed pull request #21463: [improve][broker] Refactor method
BrokerService#unloadServiceUnit
URL: https://github.com/apache/pulsar/pull/21463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mattisonchao opened a new pull request, #21463:
URL: https://github.com/apache/pulsar/pull/21463
### Motivation
Refactor method BrokerService#unloadServiceUnit to improve exception
handling, logging and method call.
### Modifications
- Add parameters NPE check
- Ignor
