[GitHub] merlimat closed issue #1024: Message Router should take `numPartitions` as parameter in choosing partition

merlimat closed issue #1024: Message Router should take `numPartitions` as parameter in choosing partition URL: https://github.com/apache/incubator-pulsar/issues/1024 This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1024: Message Router should take `numPartitions` as parameter in choosing partition

merlimat commented on issue #1024: Message Router should take `numPartitions` as parameter in choosing partition URL: https://github.com/apache/incubator-pulsar/issues/1024#issuecomment-358562413 Fixed in #1025 This is an

[GitHub] merlimat commented on issue #1060: MessageId implements Comparable

merlimat commented on issue #1060: MessageId implements Comparable URL: https://github.com/apache/incubator-pulsar/issues/1060#issuecomment-358561633 Fixed in #1065 This is an automated message from the Apache Git Service.

[GitHub] merlimat closed issue #1060: MessageId implements Comparable

merlimat closed issue #1060: MessageId implements Comparable URL: https://github.com/apache/incubator-pulsar/issues/1060 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] merlimat commented on issue #1067: Problems with Partitioned Topics which name contains -partition-N

merlimat commented on issue #1067: Problems with Partitioned Topics which name contains -partition-N URL: https://github.com/apache/incubator-pulsar/issues/1067#issuecomment-358561344 Either option (1) or (2) would be good. Ideally (2) but I don't know how difficult that would be.

[GitHub] merlimat commented on issue #1068: Improve `pulsar-broker-shaded` to shade non-pulsar dependencies

merlimat commented on issue #1068: Improve `pulsar-broker-shaded` to shade non-pulsar dependencies URL: https://github.com/apache/incubator-pulsar/issues/1068#issuecomment-358560886 Added PR in #1077 This is an automated

[GitHub] merlimat commented on issue #1075: Add documentation for Reader API

merlimat commented on issue #1075: Add documentation for Reader API URL: https://github.com/apache/incubator-pulsar/issues/1075#issuecomment-358560672 cc/ @lucperkins This is an automated message from the Apache Git

[GitHub] merlimat commented on a change in pull request #1073: Support Url Encode in Athenz auth params

merlimat commented on a change in pull request #1073: Support Url Encode in Athenz auth params URL: https://github.com/apache/incubator-pulsar/pull/1073#discussion_r162256324 ## File path:

[GitHub] merlimat closed pull request #1079: Fix shading for Kafka wrapper lib

merlimat closed pull request #1079: Fix shading for Kafka wrapper lib URL: https://github.com/apache/incubator-pulsar/pull/1079 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] merlimat commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers

merlimat commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers URL: https://github.com/apache/incubator-pulsar/pull/1078#discussion_r162250004 ## File path:

[GitHub] merlimat commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers

merlimat commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers URL: https://github.com/apache/incubator-pulsar/pull/1078#discussion_r162249976 ## File path:

[GitHub] merlimat commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers

merlimat commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers URL: https://github.com/apache/incubator-pulsar/pull/1078#discussion_r162249972 ## File path:

[GitHub] merlimat commented on issue #1079: Fix shading for Kafka wrapper lib

merlimat commented on issue #1079: Fix shading for Kafka wrapper lib URL: https://github.com/apache/incubator-pulsar/pull/1079#issuecomment-358537215 retest this please This is an automated message from the Apache Git

[GitHub] sschepens commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers

sschepens commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers URL: https://github.com/apache/incubator-pulsar/pull/1078#discussion_r162240790 ## File path:

[GitHub] sschepens commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers

sschepens commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers URL: https://github.com/apache/incubator-pulsar/pull/1078#discussion_r162240695 ## File path:

[GitHub] sschepens commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers

sschepens commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers URL: https://github.com/apache/incubator-pulsar/pull/1078#discussion_r162240546 ## File path:

[GitHub] sschepens commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers

sschepens commented on a change in pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers URL: https://github.com/apache/incubator-pulsar/pull/1078#discussion_r162240837 ## File path:

[GitHub] sschepens commented on issue #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers

sschepens commented on issue #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers URL: https://github.com/apache/incubator-pulsar/pull/1078#issuecomment-358524936 These chances are great, I was thinking of making similar ones today. Maybe se could replace `coalesce`

[GitHub] merlimat opened a new pull request #1079: Fix shading for Kafka wrapper lib

merlimat opened a new pull request #1079: Fix shading for Kafka wrapper lib URL: https://github.com/apache/incubator-pulsar/pull/1079 ### Motivation Currently the `pulsar-client-kafka` is pulling in all the `pulsar-client-original` unshaded dependencies unlike expected. This is due

[GitHub] hrsakai commented on issue #1073: Support Url Encode in Athenz auth params

hrsakai commented on issue #1073: Support Url Encode in Athenz auth params URL: https://github.com/apache/incubator-pulsar/pull/1073#issuecomment-358489667 retest this please This is an automated message from the Apache Git

[GitHub] merlimat closed pull request #1052: Move zookeeper/bookkeeper from dependency management and only specify the dependency when they are used

merlimat closed pull request #1052: Move zookeeper/bookkeeper from dependency management and only specify the dependency when they are used URL: https://github.com/apache/incubator-pulsar/pull/1052 This is a PR merged from a forked repository. As GitHub hides the original diff on merge,

[GitHub] merlimat closed pull request #1076: Various website updates

merlimat closed pull request #1076: Various website updates URL: https://github.com/apache/incubator-pulsar/pull/1076 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358489451 > @eolivelli as @merlimat suggested, it would be better to get rid of DoubleByteBuf and just keep a holder of the two byte bufs and write

[GitHub] merlimat opened a new pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers

merlimat opened a new pull request #1078: Re-implement DoubleByteBuf as a simple holder of a pair of buffers URL: https://github.com/apache/incubator-pulsar/pull/1078 ### Motivation To avoid the overhead in copying the components of a DoubleByteBuf into a temp buffer, we should

[GitHub] merlimat commented on issue #1076: Various website updates

merlimat commented on issue #1076: Various website updates URL: https://github.com/apache/incubator-pulsar/pull/1076#issuecomment-358475475 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat opened a new pull request #1077: Shade all broker dependencies

merlimat opened a new pull request #1077: Shade all broker dependencies URL: https://github.com/apache/incubator-pulsar/pull/1077 ### Motivation In #914, we've added the `pulsar-broker-shaded` artifact to allow embedding Pulsar broker into other JVM apps and avoiding conflicts with

[GitHub] eolivelli commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

eolivelli commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358444282 I am going to pick you your latest change as I am going to cut I minor release for BK. The idea of dropping DBB is ok for me but

[GitHub] eolivelli commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

eolivelli commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358440484 We have to.keep only the isDirect() change This is an automated message

[GitHub] eolivelli commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

eolivelli commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358440313 Mm so it is better to revert that change from bk too I guess. @merlimat @sijie

[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358439676 @merlimat yes, It is related to the changes i made to `public ByteBuffer[] nioBuffers()`, they are not feasible right now, I made them

[GitHub] merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358418319 @sschepens I'm seeing some failures in the test that seem to be related with the change: For example:

[GitHub] merlimat closed pull request #1005: Load-balancer consider max-topic threshold on broker-ownership selection

merlimat closed pull request #1005: Load-balancer consider max-topic threshold on broker-ownership selection URL: https://github.com/apache/incubator-pulsar/pull/1005 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] sijie commented on a change in pull request #1044: Compact algo

sijie commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162148242 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed to

[GitHub] merlimat opened a new issue #1074: Document features and usage of Pulsar proxy

merlimat opened a new issue #1074: Document features and usage of Pulsar proxy URL: https://github.com/apache/incubator-pulsar/issues/1074 We don't have much documentation around the proxy: * What problems it solves * How to run it * How to expose it..

[GitHub] sijie commented on a change in pull request #1044: Compact algo

sijie commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162144906 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed to

[GitHub] merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358376813 ... and I guess that was what was making the ManagedLedger failing when upgrading Netty to 4.1.19 in this PR.

[GitHub] merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358376517 Thanks, I forgot we had the same `DoubleByteBuf` in BK code as well. (still looking to get rid of it.. :) )

[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358375422 @merlimat we need to change this in yahoo's fork of bookkeeper as well, I made a PR https://github.com/yahoo/bookkeeper/pull/16

[GitHub] merlimat commented on a change in pull request #1008: Allow user to specify listener on subscriber or creation of reader

merlimat commented on a change in pull request #1008: Allow user to specify listener on subscriber or creation of reader URL: https://github.com/apache/incubator-pulsar/pull/1008#discussion_r162117127 ## File path:

[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358368557 > @sschepens Regarding the merge access, probably you have check again https://gitbox.apache.org/setup/ I was missing the apache

[GitHub] merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358366440 @sschepens Regarding the merge access, probably you have check again https://gitbox.apache.org/setup/

[GitHub] merlimat closed pull request #1039: Serialization and Deserialization for RawMessage

merlimat closed pull request #1039: Serialization and Deserialization for RawMessage URL: https://github.com/apache/incubator-pulsar/pull/1039 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] merlimat closed pull request #1065: Issue 1060: changes make MessageId Comparable

merlimat closed pull request #1065: Issue 1060: changes make MessageId Comparable URL: https://github.com/apache/incubator-pulsar/pull/1065 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] merlimat closed issue #1034: No source code formatter settings for C++ client

merlimat closed issue #1034: No source code formatter settings for C++ client URL: https://github.com/apache/incubator-pulsar/issues/1034 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] merlimat closed pull request #1038: ENH: Add C++ code auto-formatting option

merlimat closed pull request #1038: ENH: Add C++ code auto-formatting option URL: https://github.com/apache/incubator-pulsar/pull/1038 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r162066566 ## File path:

[GitHub] ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r162068413 ## File path:

[GitHub] ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r162069848 ## File path:

[GitHub] ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r162067685 ## File path:

[GitHub] ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r162068691 ## File path:

[GitHub] ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

ivankelly commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r162066693 ## File path:

[GitHub] ivankelly commented on issue #1044: Compact algo

ivankelly commented on issue #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#issuecomment-358322139 Going to wait for #1066 so the algorithm can be made async. This is an automated message from

[GitHub] ivankelly commented on a change in pull request #1044: Compact algo

ivankelly commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162063093 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed

[GitHub] ivankelly commented on a change in pull request #1044: Compact algo

ivankelly commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162053569 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed

[GitHub] eolivelli commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12

eolivelli commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358301672 @sschepens I am tring to port this change to bookkeeper, but I think there is a problem, see

[GitHub] ivankelly commented on a change in pull request #1044: Compact algo

ivankelly commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162033769 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed

[GitHub] ivankelly commented on a change in pull request #1044: Compact algo

ivankelly commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162021075 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed

[GitHub] ivankelly commented on a change in pull request #1044: Compact algo

ivankelly commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162017440 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed

[GitHub] ivankelly commented on a change in pull request #1044: Compact algo

ivankelly commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162016806 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed

[GitHub] sijie commented on a change in pull request #1044: Compact algo

sijie commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162010094 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed to

[GitHub] sijie commented on a change in pull request #1044: Compact algo

sijie commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162010094 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed to

[GitHub] sijie commented on a change in pull request #1044: Compact algo

sijie commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162005450 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed to

[GitHub] sijie commented on a change in pull request #1044: Compact algo

sijie commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162007603 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed to

[GitHub] sijie commented on a change in pull request #1044: Compact algo

sijie commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162004231 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed to

[GitHub] sijie commented on a change in pull request #1044: Compact algo

sijie commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162010094 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed to

[GitHub] sijie commented on a change in pull request #1044: Compact algo

sijie commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162008735 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed to

[GitHub] sijie commented on a change in pull request #1044: Compact algo

sijie commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162005189 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed to

[GitHub] sijie commented on a change in pull request #1044: Compact algo

sijie commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162011888 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed to

[GitHub] sijie commented on a change in pull request #1044: Compact algo

sijie commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r162005026 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/Compactor.java ## @@ -0,0 +1,205 @@ +/** + * Licensed to

[GitHub] hrsakai commented on issue #1073: Support Url Encode in Athenz auth params

hrsakai commented on issue #1073: Support Url Encode in Athenz auth params URL: https://github.com/apache/incubator-pulsar/pull/1073#issuecomment-358261238 retest this please This is an automated message from the Apache Git

[GitHub] hrsakai commented on issue #1073: Support Url Encode in Athenz auth params

hrsakai commented on issue #1073: Support Url Encode in Athenz auth params URL: https://github.com/apache/incubator-pulsar/pull/1073#issuecomment-358235175 retest this please This is an automated message from the Apache Git

[GitHub] hrsakai opened a new pull request #1073: Support Url Encode in Athenz auth params

hrsakai opened a new pull request #1073: Support Url Encode in Athenz auth params URL: https://github.com/apache/incubator-pulsar/pull/1073 ### Motivation Currently, only support base64 for privatekey encoding format. ### Modifications - Support url encode, too. - And