[GitHub] sijie commented on a change in pull request #1089: WIP - PIP-12 Introduce builder for creating Producer Consumer Reader

2018-01-31 Thread GitBox
sijie commented on a change in pull request #1089: WIP - PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r165277422 ## File path:

[GitHub] sijie commented on issue #1127: Issue #1119: move dockerfile for pulsar dcos prometheus into pulsar repo

2018-01-31 Thread GitBox
sijie commented on issue #1127: Issue #1119: move dockerfile for pulsar dcos prometheus into pulsar repo URL: https://github.com/apache/incubator-pulsar/pull/1127#issuecomment-362181645 retest this please This is an

[GitHub] sijie commented on issue #1163: Debump netty version by 1 due to ObjectCleaner bug

2018-01-31 Thread GitBox
sijie commented on issue #1163: Debump netty version by 1 due to ObjectCleaner bug URL: https://github.com/apache/incubator-pulsar/pull/1163#issuecomment-362181303 retest this please This is an automated message from the

[GitHub] sijie commented on issue #1161: Remove deprecation warnings related to access of PoolArenaMetric

2018-01-31 Thread GitBox
sijie commented on issue #1161: Remove deprecation warnings related to access of PoolArenaMetric URL: https://github.com/apache/incubator-pulsar/pull/1161#issuecomment-362181222 retest this please. This is an automated

[GitHub] sijie commented on a change in pull request #1162: Project-wide Checkstyle Config

2018-01-31 Thread GitBox
sijie commented on a change in pull request #1162: Project-wide Checkstyle Config URL: https://github.com/apache/incubator-pulsar/pull/1162#discussion_r165275402 ## File path: buildtools/pom.xml ## @@ -0,0 +1,36 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] sijie commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-01-31 Thread GitBox
sijie commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r165272868 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@

[GitHub] sijie commented on issue #1089: WIP - PIP-12 Introduce builder for creating Producer Consumer Reader

2018-01-31 Thread GitBox
sijie commented on issue #1089: WIP - PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#issuecomment-362168192 /cc @lucperkins This is an automated

[GitHub] merlimat closed pull request #1157: Allow to override the auto-detected NIC speed limit

2018-01-31 Thread GitBox
merlimat closed pull request #1157: Allow to override the auto-detected NIC speed limit URL: https://github.com/apache/incubator-pulsar/pull/1157 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: Allow to override the auto-detected NIC speed limit (#1157)

2018-01-31 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6154e3c Allow to override the

[GitHub] merlimat closed issue #1149: Network interface max speed information can be unreliable on VMs

2018-01-31 Thread GitBox
merlimat closed issue #1149: Network interface max speed information can be unreliable on VMs URL: https://github.com/apache/incubator-pulsar/issues/1149 This is an automated message from the Apache Git Service. To respond

[GitHub] merlimat closed pull request #1086: Pulsar proxy documentation

2018-01-31 Thread GitBox
merlimat closed pull request #1086: Pulsar proxy documentation URL: https://github.com/apache/incubator-pulsar/pull/1086 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] merlimat opened a new pull request #1164: Remove toString() invocation in dispatcher path

2018-01-31 Thread GitBox
merlimat opened a new pull request #1164: Remove toString() invocation in dispatcher path URL: https://github.com/apache/incubator-pulsar/pull/1164 ### Motivation During message dispatch a `Subscription.toString()` is invoked for each message (or batch) with no purpose other than

[GitHub] ivankelly opened a new pull request #1163: Debump netty version by 1 due to ObjectCleaner bug

2018-01-31 Thread GitBox
ivankelly opened a new pull request #1163: Debump netty version by 1 due to ObjectCleaner bug URL: https://github.com/apache/incubator-pulsar/pull/1163 The ObjectCleaner can possibly keep a process alive forever with netty 4.1.20 since it is not a daemon thread. See:

[incubator-pulsar] branch asf-site updated: Updated site at revision 7e7d0fd

2018-01-31 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new d01d9c3 Updated site at revision

[GitHub] lucperkins commented on issue #1120: Reader interface docs update

2018-01-31 Thread GitBox
lucperkins commented on issue #1120: Reader interface docs update URL: https://github.com/apache/incubator-pulsar/pull/1120#issuecomment-362103618 retest this please This is an automated message from the Apache Git Service.

[GitHub] merlimat closed pull request #1158: Links to archived releases should be using https

2018-01-31 Thread GitBox
merlimat closed pull request #1158: Links to archived releases should be using https URL: https://github.com/apache/incubator-pulsar/pull/1158 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] merlimat commented on issue #1042: Update maven compiler plugin to newest version

2018-01-31 Thread GitBox
merlimat commented on issue #1042: Update maven compiler plugin to newest version URL: https://github.com/apache/incubator-pulsar/pull/1042#issuecomment-362087513 yes, I think I cleaned it before This is an automated message

[GitHub] ivankelly commented on issue #1042: Update maven compiler plugin to newest version

2018-01-31 Thread GitBox
ivankelly commented on issue #1042: Update maven compiler plugin to newest version URL: https://github.com/apache/incubator-pulsar/pull/1042#issuecomment-362086914 @merlimat how did you generate the tarball? did you clean first?

[GitHub] merlimat commented on issue #1042: Update maven compiler plugin to newest version

2018-01-31 Thread GitBox
merlimat commented on issue #1042: Update maven compiler plugin to newest version URL: https://github.com/apache/incubator-pulsar/pull/1042#issuecomment-362085804 @rdhabalia Do you have any suspicion on what could be wrong here?

[GitHub] merlimat commented on issue #1042: Update maven compiler plugin to newest version

2018-01-31 Thread GitBox
merlimat commented on issue #1042: Update maven compiler plugin to newest version URL: https://github.com/apache/incubator-pulsar/pull/1042#issuecomment-362085632 @ivankelly I'm still getting these errors when starting broker/bookies now from a bin tgz after this change: ```

[GitHub] merlimat opened a new pull request #1158: Links to archived releases should be using https

2018-01-31 Thread GitBox
merlimat opened a new pull request #1158: Links to archived releases should be using https URL: https://github.com/apache/incubator-pulsar/pull/1158 ### Motivation This should be the last fix required for #986. The download links for archived releases signatures were using http

[GitHub] merlimat commented on issue #1158: Links to archived releases should be using https

2018-01-31 Thread GitBox
merlimat commented on issue #1158: Links to archived releases should be using https URL: https://github.com/apache/incubator-pulsar/pull/1158#issuecomment-362054758 Reopening since this needs to be merged before This is an

[GitHub] joefk commented on issue #1158: Links to archived releases should be using https

2018-01-31 Thread GitBox
joefk commented on issue #1158: Links to archived releases should be using https URL: https://github.com/apache/incubator-pulsar/pull/1158#issuecomment-362053565 ? This is an automated message from the Apache Git Service. To

[GitHub] joefk closed pull request #1158: Links to archived releases should be using https

2018-01-31 Thread GitBox
joefk closed pull request #1158: Links to archived releases should be using https URL: https://github.com/apache/incubator-pulsar/pull/1158 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] merlimat opened a new issue #1160: Intermittent test failure in ResendRequestTest.testSharedSingleAckedPartitionedTopic

2018-01-31 Thread GitBox
merlimat opened a new issue #1160: Intermittent test failure in ResendRequestTest.testSharedSingleAckedPartitionedTopic URL: https://github.com/apache/incubator-pulsar/issues/1160 Seen in

[GitHub] sijie opened a new issue #1159: Update bookkeeper version to apache release

2018-01-31 Thread GitBox
sijie opened a new issue #1159: Update bookkeeper version to apache release URL: https://github.com/apache/incubator-pulsar/issues/1159 Since we are close to merging yahoo bk changes to apache, it is a good time to start integrating pulsar with the latest apache version. This task

[GitHub] merlimat commented on issue #536: Added CMake build file and instructions for Pulsar Wireshark dissector

2018-01-31 Thread GitBox
merlimat commented on issue #536: Added CMake build file and instructions for Pulsar Wireshark dissector URL: https://github.com/apache/incubator-pulsar/pull/536#issuecomment-362043643 retest this please This is an automated

[GitHub] merlimat commented on issue #536: Added CMake build file and instructions for Pulsar Wireshark dissector

2018-01-31 Thread GitBox
merlimat commented on issue #536: Added CMake build file and instructions for Pulsar Wireshark dissector URL: https://github.com/apache/incubator-pulsar/pull/536#issuecomment-362043643 retest this please This is an automated

[GitHub] merlimat closed pull request #1135: Added infinite time retention configuration option

2018-01-31 Thread GitBox
merlimat closed pull request #1135: Added infinite time retention configuration option URL: https://github.com/apache/incubator-pulsar/pull/1135 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Added infinite time retention configuration option (#1135)

2018-01-31 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1bca601 Added infinite time

[GitHub] merlimat opened a new pull request #1158: Links to archived releases should be using https

2018-01-31 Thread GitBox
merlimat opened a new pull request #1158: Links to archived releases should be using https URL: https://github.com/apache/incubator-pulsar/pull/1158 ### Motivation This should be the last fix required for #986. The download links for archived releases signatures were using http

[GitHub] jai1 commented on issue #1124: Support Pulsar proxy from C++/Python client library

2018-01-31 Thread GitBox
jai1 commented on issue #1124: Support Pulsar proxy from C++/Python client library URL: https://github.com/apache/incubator-pulsar/pull/1124#issuecomment-362012215 Can we create an Issue/Task to add tests for this feature?

[GitHub] merlimat commented on issue #1133: Property name in documentation is incorrect

2018-01-31 Thread GitBox
merlimat commented on issue #1133: Property name in documentation is incorrect URL: https://github.com/apache/incubator-pulsar/pull/1133#issuecomment-362011659 retest this please This is an automated message from the Apache

[GitHub] merlimat commented on issue #1133: Property name in documentation is incorrect

2018-01-31 Thread GitBox
merlimat commented on issue #1133: Property name in documentation is incorrect URL: https://github.com/apache/incubator-pulsar/pull/1133#issuecomment-362011659 retest this please This is an automated message from the Apache

[GitHub] merlimat commented on issue #1140: Remove master/slave terminology from Pulsar (WIP)

2018-01-31 Thread GitBox
merlimat commented on issue #1140: Remove master/slave terminology from Pulsar (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1140#issuecomment-362011597 retest this please This is an automated message from the

[GitHub] merlimat commented on issue #1140: Remove master/slave terminology from Pulsar (WIP)

2018-01-31 Thread GitBox
merlimat commented on issue #1140: Remove master/slave terminology from Pulsar (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1140#issuecomment-362011597 retest this please This is an automated message from the

[GitHub] jai1 commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library

2018-01-31 Thread GitBox
jai1 commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library URL: https://github.com/apache/incubator-pulsar/pull/1124#discussion_r164559651 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ## @@ -114,8 +115,9 @@

[GitHub] merlimat commented on issue #1124: Support Pulsar proxy from C++/Python client library

2018-01-31 Thread GitBox
merlimat commented on issue #1124: Support Pulsar proxy from C++/Python client library URL: https://github.com/apache/incubator-pulsar/pull/1124#issuecomment-362010420 @jai1 @saandrews @rdhabalia Can you take another look at this?

[GitHub] merlimat closed pull request #437: Make cache put watch even when node doesn't exist yet

2018-01-31 Thread GitBox
merlimat closed pull request #437: Make cache put watch even when node doesn't exist yet URL: https://github.com/apache/incubator-pulsar/pull/437 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] merlimat closed pull request #1115: In Kafka consumer wrapper, group multiple messages when the app polls

2018-01-31 Thread GitBox
merlimat closed pull request #1115: In Kafka consumer wrapper, group multiple messages when the app polls URL: https://github.com/apache/incubator-pulsar/pull/1115 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[incubator-pulsar] branch master updated: In Kafka consumer wrapper, group multiple messages when the app polls (#1115)

2018-01-31 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 99fb872 In Kafka consumer wrapper,

[incubator-pulsar] branch master updated: Added REST handler to create a subscription on a topic (#1151)

2018-01-31 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 98355ca Added REST handler to create

[GitHub] maskit commented on a change in pull request #1147: Add support for new configration interface to AuthenticaionTls

2018-01-31 Thread GitBox
maskit commented on a change in pull request #1147: Add support for new configration interface to AuthenticaionTls URL: https://github.com/apache/incubator-pulsar/pull/1147#discussion_r165090213 ## File path:

[GitHub] zhaijack commented on issue #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-01-31 Thread GitBox
zhaijack commented on issue #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#issuecomment-361909771 rebased master to fix conflicts