[incubator-pulsar] branch master updated: Fix znode path creation for proxies. (#1249)

2018-02-18 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 27d87d8 Fix znode path creation for p

[GitHub] merlimat closed pull request #1249: Fix v2 namespace policies znode path in proxy handlers

2018-02-18 Thread GitBox
merlimat closed pull request #1249: Fix v2 namespace policies znode path in proxy handlers URL: https://github.com/apache/incubator-pulsar/pull/1249 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode.

2018-02-18 Thread GitBox
merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#discussion_r168991016 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java ## @@ -146,4

[GitHub] merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode.

2018-02-18 Thread GitBox
merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#discussion_r168990909 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java ## @@ -41,16

[GitHub] merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode.

2018-02-18 Thread GitBox
merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#discussion_r168991056 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java ## @@ -146,4

[GitHub] merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode.

2018-02-18 Thread GitBox
merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#discussion_r168990868 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java ## @@ -41,16

[GitHub] cckellogg opened a new pull request #1249: Fix znode path creation for proxies.

2018-02-18 Thread GitBox
cckellogg opened a new pull request #1249: Fix znode path creation for proxies. URL: https://github.com/apache/incubator-pulsar/pull/1249 Fix the znode path creation in the proxies. This is an automated message from the Apache

[GitHub] jai1 commented on issue #1246: Separating configuration for client and server trust store

2018-02-18 Thread GitBox
jai1 commented on issue #1246: Separating configuration for client and server trust store URL: https://github.com/apache/incubator-pulsar/pull/1246#issuecomment-366592110 retest this please This is an automated message from

[GitHub] jai1 commented on issue #1248: Start Proxy in TLS only mode.

2018-02-18 Thread GitBox
jai1 commented on issue #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#issuecomment-366590381 @merlimat - have addressed your review comments Had to change the ports data type to integer else you get ``` java.lang.IllegalArgumentExcep

[GitHub] jai1 commented on a change in pull request #1246: Separating configuration for client and server trust store

2018-02-18 Thread GitBox
jai1 commented on a change in pull request #1246: Separating configuration for client and server trust store URL: https://github.com/apache/incubator-pulsar/pull/1246#discussion_r168986187 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfigurati

[GitHub] merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode.

2018-02-18 Thread GitBox
merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#discussion_r168985548 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java ## @@ -41,11

[GitHub] jai1 commented on a change in pull request #1248: Start Proxy in TLS only mode.

2018-02-18 Thread GitBox
jai1 commented on a change in pull request #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#discussion_r168971509 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java ## @@ -41,11 +41,

[incubator-pulsar] branch master updated: Fix redirect url on proxy to honor TLS (#1243)

2018-02-18 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 42b9c56 Fix redirect url on proxy to

[GitHub] merlimat closed pull request #1243: Fix redirect url on proxy to honor TLS

2018-02-18 Thread GitBox
merlimat closed pull request #1243: Fix redirect url on proxy to honor TLS URL: https://github.com/apache/incubator-pulsar/pull/1243 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a for

[GitHub] merlimat commented on a change in pull request #1246: Separating configuration for client and server trust store

2018-02-18 Thread GitBox
merlimat commented on a change in pull request #1246: Separating configuration for client and server trust store URL: https://github.com/apache/incubator-pulsar/pull/1246#discussion_r168958879 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfigu

[GitHub] merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode.

2018-02-18 Thread GitBox
merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#discussion_r168958826 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java ## @@ -41,11

[GitHub] merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode.

2018-02-18 Thread GitBox
merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#discussion_r168958845 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConfiguration.java ## @@ -41,11

[GitHub] merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode.

2018-02-18 Thread GitBox
merlimat commented on a change in pull request #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#discussion_r168958771 ## File path: conf/proxy.conf ## @@ -18,10 +18,10 @@ # # Zookeeper quorum connection string (comma-separa

[GitHub] merlimat commented on issue #1242: Change HTTP status code which WebSocket proxy returns to producer whe?

2018-02-18 Thread GitBox
merlimat commented on issue #1242: Change HTTP status code which WebSocket proxy returns to producer whe? URL: https://github.com/apache/incubator-pulsar/pull/1242#issuecomment-366531357 @massakam One thing that might also help is to include the producer/consumer exception message in the 5

[incubator-pulsar] branch master updated: Fix broker conf comments (#1247)

2018-02-18 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 212d03f Fix broker conf comments (#12

[GitHub] merlimat closed pull request #1247: Fix broker conf comments

2018-02-18 Thread GitBox
merlimat closed pull request #1247: Fix broker conf comments URL: https://github.com/apache/incubator-pulsar/pull/1247 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull requ

[GitHub] jai1 opened a new pull request #1248: Start Proxy in TLS only mode.

2018-02-18 Thread GitBox
jai1 opened a new pull request #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248 Disable listening on non TLS ports. I was thinking of using the same approach in TLS port and getting of tlsEnabledFlag - let me know if you are ok with the a

[GitHub] jai1 commented on issue #1243: Fix redirect url on proxy to honor TLS

2018-02-18 Thread GitBox
jai1 commented on issue #1243: Fix redirect url on proxy to honor TLS URL: https://github.com/apache/incubator-pulsar/pull/1243#issuecomment-366504609 retest this please This is an automated message from the Apache Git Service