[GitHub] nkurihar commented on issue #1255: Add namespace policy for max clients

2018-02-21 Thread GitBox
nkurihar commented on issue #1255: Add namespace policy for max clients URL: https://github.com/apache/incubator-pulsar/pull/1255#issuecomment-367553371 We consider the following situation: * Default: limit the number of max clients (e.g. 100) * For namespaces where topics are 'huge':

[GitHub] massakam commented on issue #1242: [WIP] Change HTTP status code which WebSocket proxy returns to producer whe?

2018-02-21 Thread GitBox
massakam commented on issue #1242: [WIP] Change HTTP status code which WebSocket proxy returns to producer whe? URL: https://github.com/apache/incubator-pulsar/pull/1242#issuecomment-367536165 @merlimat > One thing that might also help is to include the producer/consumer exception mess

[GitHub] zhaijack commented on a change in pull request #1269: Issue #1237: support builder for topicsConsumer

2018-02-21 Thread GitBox
zhaijack commented on a change in pull request #1269: Issue #1237: support builder for topicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1269#discussion_r169842049 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java ###

[GitHub] sijie commented on a change in pull request #1269: Issue #1237: support builder for topicsConsumer

2018-02-21 Thread GitBox
sijie commented on a change in pull request #1269: Issue #1237: support builder for topicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1269#discussion_r169837431 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java ##

[GitHub] massakam commented on issue #1242: [WIP] Change HTTP status code which WebSocket proxy returns to producer whe?

2018-02-21 Thread GitBox
massakam commented on issue #1242: [WIP] Change HTTP status code which WebSocket proxy returns to producer whe? URL: https://github.com/apache/incubator-pulsar/pull/1242#issuecomment-367536165 retest this please This is an au

[GitHub] zhaijack commented on a change in pull request #1269: Issue #1237: support builder for topicsConsumer

2018-02-21 Thread GitBox
zhaijack commented on a change in pull request #1269: Issue #1237: support builder for topicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1269#discussion_r169826798 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBuilderImpl.java ##

[GitHub] merlimat commented on a change in pull request #1269: Issue #1237: support builder for topicsConsumer

2018-02-21 Thread GitBox
merlimat commented on a change in pull request #1269: Issue #1237: support builder for topicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1269#discussion_r169824643 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerBuilderImpl.java ##

[GitHub] zhaijack commented on issue #1100: PIP-13-1: sub-regex: Provide `TopicsConsumer` to consume from several topics under same namespace.

2018-02-21 Thread GitBox
zhaijack commented on issue #1100: PIP-13-1: sub-regex: Provide `TopicsConsumer` to consume from several topics under same namespace. URL: https://github.com/apache/incubator-pulsar/issues/1100#issuecomment-367527824 Thanks for @ivankelly and @merlimat 's review, 1103 merged

[GitHub] zhaijack closed issue #1100: PIP-13-1: sub-regex: Provide `TopicsConsumer` to consume from several topics under same namespace.

2018-02-21 Thread GitBox
zhaijack closed issue #1100: PIP-13-1: sub-regex: Provide `TopicsConsumer` to consume from several topics under same namespace. URL: https://github.com/apache/incubator-pulsar/issues/1100 This is an automated message from th

[GitHub] zhaijack commented on issue #1237: Make subscribe for TopicsConsumer using builder

2018-02-21 Thread GitBox
zhaijack commented on issue #1237: Make subscribe for TopicsConsumer using builder URL: https://github.com/apache/incubator-pulsar/issues/1237#issuecomment-367527556 PR #1269 is for this This is an automated message from the

[GitHub] zhaijack opened a new pull request #1269: Issue #1237: support builder for topicsConsumer

2018-02-21 Thread GitBox
zhaijack opened a new pull request #1269: Issue #1237: support builder for topicsConsumer URL: https://github.com/apache/incubator-pulsar/pull/1269 ### Motivation According to PIP-12, we need to support builder for topicsConsumer ### Modifications - add `ConsumerBuilder

[GitHub] rdhabalia commented on issue #1268: Add get-peer clusters admin api

2018-02-21 Thread GitBox
rdhabalia commented on issue #1268: Add get-peer clusters admin api URL: https://github.com/apache/incubator-pulsar/pull/1268#issuecomment-367523179 retest this please This is an automated message from the Apache Git Service.

[GitHub] rdhabalia commented on issue #1268: Add get-peer clusters admin api

2018-02-21 Thread GitBox
rdhabalia commented on issue #1268: Add get-peer clusters admin api URL: https://github.com/apache/incubator-pulsar/pull/1268#issuecomment-367523179 retest this please This is an automated message from the Apache Git Service.

[GitHub] zhaijack commented on issue #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-21 Thread GitBox
zhaijack commented on issue #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#issuecomment-367495140 @merlimat, Thanks for the reminder, will do the change for builder. -

[GitHub] merlimat commented on issue #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-21 Thread GitBox
merlimat commented on issue #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#issuecomment-367494452 @zhaijack Since the consumer builder changes went in already, please update the API t

[GitHub] merlimat closed pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-21 Thread GitBox
merlimat closed pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[incubator-pulsar] branch master updated: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace (#1103)

2018-02-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new d073a7c PIP-13-1/3: Provide `TopicsCo

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-21 Thread GitBox
ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r169790326 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-21 Thread GitBox
ivankelly commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167516056 ## File path: pulsar-client/src/main/java/org/apache/pulsa

[GitHub] rdhabalia opened a new pull request #1268: Add get-peer clusters admin api

2018-02-21 Thread GitBox
rdhabalia opened a new pull request #1268: Add get-peer clusters admin api URL: https://github.com/apache/incubator-pulsar/pull/1268 ### Motivation Right now, after adding peer-clusters, we don't have admin api to get configured peer-cluster for the verification. ### Modificat

[GitHub] sijie commented on issue #1267: Improve failover subscription for non-partitioned topic

2018-02-21 Thread GitBox
sijie commented on issue #1267: Improve failover subscription for non-partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1267#issuecomment-367452616 /cc @jerrypeng This is an automated message from the

[GitHub] sijie commented on issue #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-21 Thread GitBox
sijie commented on issue #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#issuecomment-367478691 ping @ivankelly can you take a look at the latest change, so that we can move forward wi

[GitHub] rdhabalia commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic

2018-02-21 Thread GitBox
rdhabalia commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic URL: https://github.com/apache/incubator-pulsar/pull/1262#discussion_r169782352 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerServ

[GitHub] jerrypeng commented on issue #1267: Improve failover subscription for non-partitioned topic

2018-02-21 Thread GitBox
jerrypeng commented on issue #1267: Improve failover subscription for non-partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1267#issuecomment-367456274 +1 This is an automated message from the Apache G

[GitHub] sijie opened a new issue #1267: Improve failover subscription for non-partitioned topic

2018-02-21 Thread GitBox
sijie opened a new issue #1267: Improve failover subscription for non-partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1267 *Problem* Currently failover subscription is sorting the consumers. so if a consumer who consumer name is always the first consumer aft

[GitHub] sijie commented on issue #1186: Pulsar FAQ

2018-02-21 Thread GitBox
sijie commented on issue #1186: Pulsar FAQ URL: https://github.com/apache/incubator-pulsar/pull/1186#issuecomment-367458649 ping @merlimat @rdhabalia ? This is an automated message from the Apache Git Service. To respond to th

[GitHub] merlimat closed pull request #1257: Compaction CLI tool

2018-02-21 Thread GitBox
merlimat closed pull request #1257: Compaction CLI tool URL: https://github.com/apache/incubator-pulsar/pull/1257 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (

[incubator-pulsar] branch master updated: Compaction CLI tool (#1257)

2018-02-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6de2652 Compaction CLI tool (#1257) 6

[GitHub] rdhabalia commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic

2018-02-21 Thread GitBox
rdhabalia commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic URL: https://github.com/apache/incubator-pulsar/pull/1262#discussion_r169758593 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerServ

[GitHub] rdhabalia commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic

2018-02-21 Thread GitBox
rdhabalia commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic URL: https://github.com/apache/incubator-pulsar/pull/1262#discussion_r169757688 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractRe

[GitHub] merlimat commented on issue #1255: Add namespace policy for max clients

2018-02-21 Thread GitBox
merlimat commented on issue #1255: Add namespace policy for max clients URL: https://github.com/apache/incubator-pulsar/pull/1255#issuecomment-367432718 > Then, how about restricting this command to only superUser like DispatchRate? For dispatch rate, there are many cases in which y

[GitHub] massakam commented on issue #1242: [WIP] Change HTTP status code which WebSocket proxy returns to producer whe?

2018-02-21 Thread GitBox
massakam commented on issue #1242: [WIP] Change HTTP status code which WebSocket proxy returns to producer whe? URL: https://github.com/apache/incubator-pulsar/pull/1242#issuecomment-367411174 retest this please This is an au

[GitHub] massakam commented on issue #1242: [WIP] Change HTTP status code which WebSocket proxy returns to producer whe?

2018-02-21 Thread GitBox
massakam commented on issue #1242: [WIP] Change HTTP status code which WebSocket proxy returns to producer whe? URL: https://github.com/apache/incubator-pulsar/pull/1242#issuecomment-367344768 retest this please This is an au

[incubator-pulsar] branch master updated: Fixed Lookup redirect logic on Proxy side (#1265)

2018-02-21 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3dbfb68 Fixed Lookup redirect logic o

[GitHub] merlimat closed pull request #1265: Fixed Lookup redirect logic on Proxy side

2018-02-21 Thread GitBox
merlimat closed pull request #1265: Fixed Lookup redirect logic on Proxy side URL: https://github.com/apache/incubator-pulsar/pull/1265 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] maskit opened a new issue #1266: Pass all Apache Podling Website Checks

2018-02-21 Thread GitBox
maskit opened a new issue #1266: Pass all Apache Podling Website Checks URL: https://github.com/apache/incubator-pulsar/issues/1266 Expected behavior All Apache Podling Website Checks are green https://whimsy.apache.org/pods/project/pulsar Actual behavior So

[GitHub] massakam commented on issue #1242: [WIP] Change HTTP status code which WebSocket proxy returns to producer whe?

2018-02-21 Thread GitBox
massakam commented on issue #1242: [WIP] Change HTTP status code which WebSocket proxy returns to producer whe? URL: https://github.com/apache/incubator-pulsar/pull/1242#issuecomment-367344768 retest this please This is an au

[GitHub] David-Jin commented on issue #1259: Is there any relationship between Yahoo Message Broker and Pulsar projects?

2018-02-21 Thread GitBox
David-Jin commented on issue #1259: Is there any relationship between Yahoo Message Broker and Pulsar projects? URL: https://github.com/apache/incubator-pulsar/issues/1259#issuecomment-367315135 @merlimat Thanks for your information! I'am considering using Pulsar in the following ap

[GitHub] XiaoZYang commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages

2018-02-21 Thread GitBox
XiaoZYang commented on a change in pull request #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages URL: https://github.com/apache/incubator-pulsar/pull/1219#discussion_r169108416 ## File path: managed-ledger/src/main/java/or

[GitHub] jai1 commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic

2018-02-21 Thread GitBox
jai1 commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic URL: https://github.com/apache/incubator-pulsar/pull/1262#discussion_r169577447 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.j

[GitHub] jai1 commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic

2018-02-21 Thread GitBox
jai1 commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic URL: https://github.com/apache/incubator-pulsar/pull/1262#discussion_r169577462 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.j

[GitHub] jai1 commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic

2018-02-21 Thread GitBox
jai1 commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic URL: https://github.com/apache/incubator-pulsar/pull/1262#discussion_r169570298 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/N

[GitHub] jai1 commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic

2018-02-21 Thread GitBox
jai1 commented on a change in pull request #1262: Broker should not start replicator for root partitioned-topic URL: https://github.com/apache/incubator-pulsar/pull/1262#discussion_r169568719 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractReplica