sijie opened a new pull request #1313: Fix the typo in shaded client-tools
module
URL: https://github.com/apache/incubator-pulsar/pull/1313
*Problem*
Because of the typo, the `circe-checksum` is not included for shading. It
will cause class conflicts on checksum classes when using
sijie opened a new pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314
This is the PR for PIP-15:
https://github.com/apache/incubator-pulsar/wiki/PIP-15:-Pulsar-Functions
The branch for review:
https://github.com/sijie/incubator-pul
sijie commented on issue #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#issuecomment-369514912
it is probably *hard* for review. we have tried to make the changes happen
under `pulsar-functions` only. the only two places changing outside of
`pulsa
sijie commented on issue #1313: Fix the typo in shaded client-tools module
URL: https://github.com/apache/incubator-pulsar/pull/1313#issuecomment-369537301
retest this please
This is an automated message from the Apache Git Se
ivankelly commented on issue #1310: Utilities for arquillian integration tests
URL: https://github.com/apache/incubator-pulsar/pull/1310#issuecomment-369538708
@merlimat added log4j2 file, remove log4j1
This is an automated me
merlimat commented on issue #1313: Fix the typo in shaded client-tools module
URL: https://github.com/apache/incubator-pulsar/pull/1313#issuecomment-369591123
retest this please
This is an automated message from the Apache Gi
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 1db47ca Fix the typo in shaded client
merlimat closed pull request #1313: Fix the typo in shaded client-tools module
URL: https://github.com/apache/incubator-pulsar/pull/1313
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
merlimat commented on issue #1313: Fix the typo in shaded client-tools module
URL: https://github.com/apache/incubator-pulsar/pull/1313#issuecomment-369591123
retest this please
This is an automated message from the Apache Gi
mgodave commented on a change in pull request #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r171607212
##
File path: pulsar-common/src/main/proto/PulsarApi.proto
##
@@ -387,6 +400,7 @@ message CommandProducerSuccess {
mgodave commented on a change in pull request #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r171608603
##
File path: pulsar-common/src/main/proto/PulsarApi.proto
##
@@ -22,6 +22,13 @@ package pulsar.proto;
option java_pac
mgodave commented on a change in pull request #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r171608954
##
File path: pulsar-common/src/main/proto/PulsarApi.proto
##
@@ -22,6 +22,13 @@ package pulsar.proto;
option java_pac
mgodave commented on a change in pull request #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r171609211
##
File path: pulsar-common/src/main/proto/PulsarApi.proto
##
@@ -197,6 +205,8 @@ message CommandSubscribe {
repea
merlimat commented on a change in pull request #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r171623263
##
File path: pulsar-common/src/main/proto/PulsarApi.proto
##
@@ -22,6 +22,13 @@ package pulsar.proto;
option java_pa
merlimat commented on a change in pull request #1297: Add Configuration to set
tlsClientAuth
URL: https://github.com/apache/incubator-pulsar/pull/1297#discussion_r171645907
##
File path: conf/broker.conf
##
@@ -207,6 +207,9 @@ tlsTrustCertsFilePath=
# Accept untrusted TLS
merlimat commented on a change in pull request #1297: Add Configuration to set
tlsClientAuth
URL: https://github.com/apache/incubator-pulsar/pull/1297#discussion_r171645907
##
File path: conf/broker.conf
##
@@ -207,6 +207,9 @@ tlsTrustCertsFilePath=
# Accept untrusted TLS
mgodave commented on a change in pull request #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#discussion_r171649091
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistry.java
##
@@ -0,0 +1,79 @@
+/
mgodave commented on a change in pull request #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#discussion_r171649406
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistry.java
##
@@ -0,0 +1,79 @@
+/
mgodave commented on a change in pull request #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#discussion_r171649771
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/schema/Schema.java
##
@@ -0,0 +1,139 @@
+/**
+ * Licensed
mgodave commented on a change in pull request #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#discussion_r171649854
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java
##
@@ -0,0 +1,274 @@
+/**
+ *
merlimat commented on a change in pull request #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r171651451
##
File path: pulsar-common/src/main/proto/PulsarApi.proto
##
@@ -22,6 +22,30 @@ package pulsar.proto;
option java_pa
merlimat commented on a change in pull request #1137: Schema registry
URL: https://github.com/apache/incubator-pulsar/pull/1137#discussion_r171652571
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java
##
@@ -0,0 +1,274 @@
+/**
+ *
mgodave opened a new pull request #1315: Remove deprecated newConnect methods
URL: https://github.com/apache/incubator-pulsar/pull/1315
The only piece of code using these methods is a test that is testing to make
sure a deprecated method still works. If there is something I'm missing please
merlimat commented on issue #1315: Remove deprecated newConnect methods
URL: https://github.com/apache/incubator-pulsar/pull/1315#issuecomment-369717424
@mgodave , the `AuthMethod` enum was used in Pulsar before we realized that
it was a problem to plug in an arbitrary authentication plugin
mgodave commented on issue #1315: Remove deprecated newConnect methods
URL: https://github.com/apache/incubator-pulsar/pull/1315#issuecomment-369718654
ok, I could not see any place it was being used other than an old test.
Feel free to close.
On Thu, Mar 1, 2018 at 1:17 PM, Matteo
mgodave commented on issue #1315: Remove deprecated newConnect methods
URL: https://github.com/apache/incubator-pulsar/pull/1315#issuecomment-369719137
ok, duh, it just registered what you are saying... yes, if there are old
clients we would want to make sure this still works.
On T
mgodave commented on issue #1315: Remove deprecated newConnect methods
URL: https://github.com/apache/incubator-pulsar/pull/1315#issuecomment-369719511
would it be acceptable to move these methods, which are only being used in
a test, to the test itself. That way it would be out of the ma
merlimat commented on issue #1315: Remove deprecated newConnect methods
URL: https://github.com/apache/incubator-pulsar/pull/1315#issuecomment-369721269
> would it be acceptable to move these methods, which are only being used in
a test, to the test itself. That way it would be out of the
merlimat commented on a change in pull request #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r171706547
##
File path: pulsar-common/src/main/proto/PulsarApi.proto
##
@@ -408,6 +408,7 @@ message CommandProducerSuccess {
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new ccf1812 Remove deprecated newConnect
merlimat closed pull request #1315: Remove deprecated newConnect methods
URL: https://github.com/apache/incubator-pulsar/pull/1315
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a forei
mgodave commented on issue #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#issuecomment-369756569
I added it then reverted it. I *think* we only need it on the server. We
can tag messages as they come in and before we persist them to the topic,
ri
merlimat commented on issue #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#issuecomment-369757306
> We can tag messages as they come in and before we persist them to the
topic, right?
That would mean that we need to re-serialize the protobuf
mgodave commented on issue #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#issuecomment-369757414
I'm updating the code. In the ServerCnx we store a list of the Producers
for a Topic. Each producer has a publishing schema associated with it and
wi
mgodave commented on issue #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232#issuecomment-369757608
yeah, I see that... OK.
On Thu, Mar 1, 2018 at 3:44 PM, Matteo Merli
wrote:
> We can tag messages as they come in and before we persist t
merlimat closed pull request #1232: Schema registry (1/4)
URL: https://github.com/apache/incubator-pulsar/pull/1232
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 21ffe2c Schema registry (1/4) (#1232)
sijie opened a new pull request #1316: Introduce a pulsar log4j2 appender
URL: https://github.com/apache/incubator-pulsar/pull/1316
### Motivation
when developing `pulsar-functions`, it would be good to log the log messages
generated by functions to pulsar, so the user can easily tai
sijie commented on issue #1316: Introduce a pulsar log4j2 appender
URL: https://github.com/apache/incubator-pulsar/pull/1316#issuecomment-369816232
NOTE:
Ideally I would like to contribute this module as part of log4j2 -
https://github.com/apache/logging-log4j2 . However we would lik
sijie commented on issue #1316: Introduce a pulsar log4j2 appender
URL: https://github.com/apache/incubator-pulsar/pull/1316#issuecomment-369817375
filed a jira issue to log4j2 to contribute this appender back to log4j2 :
https://issues.apache.org/jira/browse/LOG4J2-2280
--
yush1ga opened a new issue #1317: get/set API for namespace policy need to be
refactored
URL: https://github.com/apache/incubator-pulsar/issues/1317
Namespace policy has many properties and get/set API exists for each
property.
If we add new property, we have to create get/set API for R
sijie commented on issue #1316: Introduce a pulsar log4j2 appender
URL: https://github.com/apache/incubator-pulsar/pull/1316#issuecomment-369832942
retest this please
This is an automated message from the Apache Git Service.
T
sijie commented on issue #1317: get/set API for namespace policy need to be
refactored
URL:
https://github.com/apache/incubator-pulsar/issues/1317#issuecomment-369844601
sounds like a good approach to take. +1
This is an aut
jai1 opened a new pull request #1318: Added localhost as default advertised
address in standalone.conf
URL: https://github.com/apache/incubator-pulsar/pull/1318
@rdhabalia , @saandrews and I are unable to use standalone broker unless we
specify the advertisedAddress as localhost.
I wou
44 matches
Mail list logo
