merlimat commented on issue #1318: Added localhost as default advertised
address in standalone.conf
URL: https://github.com/apache/incubator-pulsar/pull/1318#issuecomment-369850960
The problem with that is that it would make standalone to not work outside
localhost (with default config.
merlimat commented on issue #1317: get/set API for namespace policy need to be
refactored
URL:
https://github.com/apache/incubator-pulsar/issues/1317#issuecomment-369851901
I completely agree with the goal of simplification, but I think the problem
is that each property is not of the same
merlimat closed pull request #1311: Converted main part of code to use builder
APIs with typed interface
URL: https://github.com/apache/incubator-pulsar/pull/1311
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake o
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new a64b383 Converted main part of code t
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 1499a1f Updated site at revision
sijie commented on issue #1316: Introduce a pulsar log4j2 appender
URL: https://github.com/apache/incubator-pulsar/pull/1316#issuecomment-369892134
retest this please
This is an automated message from the Apache Git Service.
T
mgodave opened a new pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319
See #1137 for reference
This is an automated message from the Apache Git Service.
To respond to the messa
merlimat commented on a change in pull request #1316: Introduce a pulsar log4j2
appender
URL: https://github.com/apache/incubator-pulsar/pull/1316#discussion_r171928903
##
File path:
pulsar-log4j2-appender/src/main/java/org/apache/pulsar/log4j2/appender/PulsarManager.java
merlimat commented on a change in pull request #1316: Introduce a pulsar log4j2
appender
URL: https://github.com/apache/incubator-pulsar/pull/1316#discussion_r171928509
##
File path: pulsar-log4j2-appender/pom.xml
##
@@ -0,0 +1,77 @@
+
+http://maven.apache.org/POM/4.0.0";
merlimat commented on a change in pull request #1316: Introduce a pulsar log4j2
appender
URL: https://github.com/apache/incubator-pulsar/pull/1316#discussion_r171930372
##
File path:
pulsar-log4j2-appender/src/main/java/org/apache/pulsar/log4j2/appender/PulsarManager.java
merlimat commented on a change in pull request #1316: Introduce a pulsar log4j2
appender
URL: https://github.com/apache/incubator-pulsar/pull/1316#discussion_r171930624
##
File path:
pulsar-log4j2-appender/src/main/java/org/apache/pulsar/log4j2/appender/PulsarManager.java
sijie commented on issue #1316: Introduce a pulsar log4j2 appender
URL: https://github.com/apache/incubator-pulsar/pull/1316#issuecomment-370019317
retest this please
This is an automated message from the Apache Git Service.
T
sijie commented on issue #1316: Introduce a pulsar log4j2 appender
URL: https://github.com/apache/incubator-pulsar/pull/1316#issuecomment-370026875
@merlimat I have addressed all your comments.
This is an automated message fro
lucperkins commented on issue #1181: Multi-topic subscription documentation
URL: https://github.com/apache/incubator-pulsar/pull/1181#issuecomment-370047766
@merlimat The scope of this PR has widened a bit to include a new version of
the Java client doc that includes the builder changes.
-
sijie closed pull request #1316: Introduce a pulsar log4j2 appender
URL: https://github.com/apache/incubator-pulsar/pull/1316
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pu
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 973fa3a Introduce a pulsar log4j2 appe
merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171901176
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java
##
@@ -125,4 +126,8 @@ void upd
merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171966347
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##
@@ -288,6 +288,13 @@ publ
merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171902129
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistry.java
##
@@ -0,0 +1,7
merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171967014
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/api/data/SchemaInfo.java
##
@@ -0,0 +1,34 @@
+/**
merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171902476
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryFormat.java
##
@@ -0,
merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171966891
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##
@@ -288,6 +288,13 @@ publ
merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171965788
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/schema/SchemaVersion.java
##
@@ -0,0 +1,26 @@
+/**
merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171967465
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaStorage.java
##
@@ -0,0 +1,83
merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r17197
##
File path: pulsar-broker/pom.xml
##
@@ -54,6 +54,12 @@
netty-all
+
+ com.google.protobuf
+
merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171965586
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/schema/Schema.java
##
@@ -0,0 +1,32 @@
+/**
+ * Li
merlimat commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171969057
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/schema/Schema.java
##
@@ -0,0 +1,32 @@
+/**
+ * Li
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171976063
##
File path: pulsar-broker/pom.xml
##
@@ -54,6 +54,12 @@
netty-all
+
+ com.google.protobuf
+
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171976063
##
File path: pulsar-broker/pom.xml
##
@@ -54,6 +54,12 @@
netty-all
+
+ com.google.protobuf
+
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171976281
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java
##
@@ -125,4 +126,8 @@ void upda
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171976424
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java
##
@@ -125,4 +126,8 @@ void upda
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171976281
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java
##
@@ -125,4 +126,8 @@ void upda
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171976581
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistry.java
##
@@ -0,0 +1,79
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171977100
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistryFormat.java
##
@@ -0,0
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171977305
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/schema/Schema.java
##
@@ -0,0 +1,32 @@
+/**
+ * Lic
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171977549
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/schema/SchemaVersion.java
##
@@ -0,0 +1,26 @@
+/**
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171977696
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##
@@ -288,6 +288,13 @@ publi
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171977969
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/api/data/SchemaInfo.java
##
@@ -0,0 +1,34 @@
+/**
+
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171978467
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaStorage.java
##
@@ -0,0 +1,83
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171979540
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/schema/SchemaVersion.java
##
@@ -0,0 +1,26 @@
+/**
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171979881
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/schema/SchemaRegistry.java
##
@@ -0,0 +1,79
merlimat commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171979261
##
File path: pulsar-functions/instance/src/main/python/log.py
##
@@ -0,0 +1,111 @@
+#!/usr/bin/env python
+#
+# Li
merlimat commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171978956
##
File path: pulsar-functions/instance/pom.xml
##
@@ -0,0 +1,227 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:
merlimat commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171980820
##
File path: pulsar-functions/python-examples/exclamation.py
##
@@ -0,0 +1,29 @@
+#!/usr/bin/env python
+#
+# Lice
merlimat commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171979907
##
File path:
pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/CounterFunction.java
##
merlimat commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171978685
##
File path: pulsar-functions/instance/pom.xml
##
@@ -0,0 +1,227 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:
merlimat commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171978365
##
File path: pulsar-functions/dist/pom.xml
##
@@ -0,0 +1,109 @@
+
merlimat commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171981261
##
File path:
pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v1/FunctionApiV1ResourceTest
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171985679
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##
@@ -288,6 +288,13 @@ publi
mgodave commented on a change in pull request #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#discussion_r171985692
##
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java
##
@@ -288,6 +288,13 @@ publi
merlimat opened a new pull request #1320: Refactored all unit tests to use new
typed API with builders for configuration
URL: https://github.com/apache/incubator-pulsar/pull/1320
### Motivation
Refactored all unit tests code to use new typed API.
Left `V1_ProducerConsumerTest
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998264
##
File path: pulsar-functions/dist/pom.xml
##
@@ -0,0 +1,109 @@
+
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998355
##
File path: pulsar-functions/instance/src/main/python/log.py
##
@@ -0,0 +1,111 @@
+#!/usr/bin/env python
+#
+# Licen
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998294
##
File path: pulsar-functions/instance/pom.xml
##
@@ -0,0 +1,227 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998313
##
File path: pulsar-functions/instance/pom.xml
##
@@ -0,0 +1,227 @@
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998450
##
File path:
pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/CounterFunction.java
#
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998495
##
File path: pulsar-functions/python-examples/exclamation.py
##
@@ -0,0 +1,29 @@
+#!/usr/bin/env python
+#
+# License
sijie commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171998515
##
File path:
pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v1/FunctionApiV1ResourceTest.ja
merlimat commented on a change in pull request #1314: PIP-15: Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1314#discussion_r171999457
##
File path:
pulsar-functions/java-examples/src/main/java/org/apache/pulsar/functions/api/examples/CounterFunction.java
##
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 44e0663 Utilities for arquillian inte
merlimat closed pull request #1310: Utilities for arquillian integration tests
URL: https://github.com/apache/incubator-pulsar/pull/1310
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
merlimat commented on issue #1320: Refactored all unit tests to use new typed
API with builders for configuration
URL: https://github.com/apache/incubator-pulsar/pull/1320#issuecomment-370122701
retest this please
This is an
merlimat commented on issue #1320: Refactored all unit tests to use new typed
API with builders for configuration
URL: https://github.com/apache/incubator-pulsar/pull/1320#issuecomment-370122701
retest this please
This is an
63 matches
Mail list logo
