[GitHub] merlimat commented on a change in pull request #1352: Delete inactive subscriptions automatically

2018-03-06 Thread GitBox
merlimat commented on a change in pull request #1352: Delete inactive subscriptions automatically URL: https://github.com/apache/incubator-pulsar/pull/1352#discussion_r172759604 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java #

[GitHub] srkukarni commented on issue #1353: Have the ability to send log messages to a topic in Python

2018-03-06 Thread GitBox
srkukarni commented on issue #1353: Have the ability to send log messages to a topic in Python URL: https://github.com/apache/incubator-pulsar/pull/1353#issuecomment-371049028 @merlimat addressed review comments. This is an a

[GitHub] yush1ga commented on a change in pull request #1352: Delete inactive subscriptions automatically

2018-03-06 Thread GitBox
yush1ga commented on a change in pull request #1352: Delete inactive subscriptions automatically URL: https://github.com/apache/incubator-pulsar/pull/1352#discussion_r172758083 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java ##

[GitHub] merlimat commented on a change in pull request #1353: Have the ability to send log messages to a topic in Python

2018-03-06 Thread GitBox
merlimat commented on a change in pull request #1353: Have the ability to send log messages to a topic in Python URL: https://github.com/apache/incubator-pulsar/pull/1353#discussion_r172756910 ## File path: pulsar-functions/instance/src/main/python/log.py ## @@ -34,6 +34,1

[GitHub] merlimat commented on a change in pull request #1353: Have the ability to send log messages to a topic in Python

2018-03-06 Thread GitBox
merlimat commented on a change in pull request #1353: Have the ability to send log messages to a topic in Python URL: https://github.com/apache/incubator-pulsar/pull/1353#discussion_r172757186 ## File path: pulsar-functions/instance/src/main/python/log.py ## @@ -34,6 +34,1

[GitHub] merlimat commented on a change in pull request #1353: Have the ability to send log messages to a topic in Python

2018-03-06 Thread GitBox
merlimat commented on a change in pull request #1353: Have the ability to send log messages to a topic in Python URL: https://github.com/apache/incubator-pulsar/pull/1353#discussion_r172757389 ## File path: pulsar-functions/instance/src/main/python/log.py ## @@ -34,6 +34,1

[GitHub] merlimat commented on a change in pull request #1352: Delete inactive subscriptions automatically

2018-03-06 Thread GitBox
merlimat commented on a change in pull request #1352: Delete inactive subscriptions automatically URL: https://github.com/apache/incubator-pulsar/pull/1352#discussion_r172754452 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java #

[GitHub] merlimat commented on a change in pull request #1352: Delete inactive subscriptions automatically

2018-03-06 Thread GitBox
merlimat commented on a change in pull request #1352: Delete inactive subscriptions automatically URL: https://github.com/apache/incubator-pulsar/pull/1352#discussion_r172754555 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.ja

[incubator-pulsar] branch master updated: Pulsar Functions documentation (#1350)

2018-03-06 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a0623d5 Pulsar Functions documentation

[GitHub] sijie closed pull request #1350: Pulsar Functions documentation

2018-03-06 Thread GitBox
sijie closed pull request #1350: Pulsar Functions documentation URL: https://github.com/apache/incubator-pulsar/pull/1350 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull r

[GitHub] sijie commented on issue #1350: Pulsar Functions documentation

2018-03-06 Thread GitBox
sijie commented on issue #1350: Pulsar Functions documentation URL: https://github.com/apache/incubator-pulsar/pull/1350#issuecomment-371041397 Talked with @merlimat offline, let's merge this one. so the docs will go out, then we start have changes interating and improve it. --

[GitHub] srkukarni opened a new pull request #1353: Have the ability to send log messages to a topic in Python

2018-03-06 Thread GitBox
srkukarni opened a new pull request #1353: Have the ability to send log messages to a topic in Python URL: https://github.com/apache/incubator-pulsar/pull/1353 ### Motivation We want to allow users to specify a log topic where all function logging should end up in. This change is

[GitHub] srkukarni commented on issue #1353: Have the ability to send log messages to a topic in Python

2018-03-06 Thread GitBox
srkukarni commented on issue #1353: Have the ability to send log messages to a topic in Python URL: https://github.com/apache/incubator-pulsar/pull/1353#issuecomment-371039309 @merlimat @sijie This is an automated message fr

[incubator-pulsar] branch master updated: Shade pulsar-functions-runtime instead of pulsar-functions-worker (#1351)

2018-03-06 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0ac6b9a Shade pulsar-functions-runtime

[GitHub] sijie closed pull request #1351: Shade pulsar-functions-runtime instead of pulsar-functions-worker

2018-03-06 Thread GitBox
sijie closed pull request #1351: Shade pulsar-functions-runtime instead of pulsar-functions-worker URL: https://github.com/apache/incubator-pulsar/pull/1351 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prov

[GitHub] yush1ga opened a new pull request #1352: Delete inactive subscriptions automatically

2018-03-06 Thread GitBox
yush1ga opened a new pull request #1352: Delete inactive subscriptions automatically URL: https://github.com/apache/incubator-pulsar/pull/1352 ### Motivation Some our tenants keep unnecessary subscriptions. It may cause lack of storages, producer_request_hold and so on. ###

[GitHub] sijie commented on issue #1351: Shade pulsar-functions-runtime instead of pulsar-functions-worker

2018-03-06 Thread GitBox
sijie commented on issue #1351: Shade pulsar-functions-runtime instead of pulsar-functions-worker URL: https://github.com/apache/incubator-pulsar/pull/1351#issuecomment-371007688 merged to latest master since the new `bookkeeper-server-tests-shaded` is already published to apache snapshot.

[GitHub] sijie commented on issue #1347: Enforce timeout on all TestNG tests, thread dump on timeout

2018-03-06 Thread GitBox
sijie commented on issue #1347: Enforce timeout on all TestNG tests, thread dump on timeout URL: https://github.com/apache/incubator-pulsar/pull/1347#issuecomment-370998870 Good job! This is an automated message from the Apac

[incubator-pulsar] branch master updated: Base module for Arquillian integration tests (#1349)

2018-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e0fb00b Base module for Arquillian in

[GitHub] merlimat closed pull request #1349: Base module for Arquillian integration tests

2018-03-06 Thread GitBox
merlimat closed pull request #1349: Base module for Arquillian integration tests URL: https://github.com/apache/incubator-pulsar/pull/1349 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] merlimat closed pull request #1335: Log phases in two phase compaction

2018-03-06 Thread GitBox
merlimat closed pull request #1335: Log phases in two phase compaction URL: https://github.com/apache/incubator-pulsar/pull/1335 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-pulsar] branch master updated: Log phases in two phase compaction (#1335)

2018-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9c6e124 Log phases in two phase compa

[GitHub] jai1 commented on a change in pull request #1322: Use private impl for MessageId in c++ client

2018-03-06 Thread GitBox
jai1 commented on a change in pull request #1322: Use private impl for MessageId in c++ client URL: https://github.com/apache/incubator-pulsar/pull/1322#discussion_r172705462 ## File path: pulsar-client-cpp/lib/MessageId.cc ## @@ -30,43 +29,51 @@ namespace pulsar { -M

[GitHub] jai1 commented on a change in pull request #1322: Use private impl for MessageId in c++ client

2018-03-06 Thread GitBox
jai1 commented on a change in pull request #1322: Use private impl for MessageId in c++ client URL: https://github.com/apache/incubator-pulsar/pull/1322#discussion_r172705241 ## File path: pulsar-client-cpp/lib/MessageId.cc ## @@ -30,43 +29,51 @@ namespace pulsar { -M

[GitHub] jai1 commented on a change in pull request #1322: Use private impl for MessageId in c++ client

2018-03-06 Thread GitBox
jai1 commented on a change in pull request #1322: Use private impl for MessageId in c++ client URL: https://github.com/apache/incubator-pulsar/pull/1322#discussion_r172704532 ## File path: pulsar-client-cpp/include/pulsar/MessageId.h ## @@ -50,34 +47,44 @@ class MessageId

[GitHub] jai1 commented on a change in pull request #1322: Use private impl for MessageId in c++ client

2018-03-06 Thread GitBox
jai1 commented on a change in pull request #1322: Use private impl for MessageId in c++ client URL: https://github.com/apache/incubator-pulsar/pull/1322#discussion_r172706345 ## File path: pulsar-client-cpp/lib/MessageId.cc ## @@ -75,38 +82,81 @@ void MessageId::serialize(

[GitHub] sijie commented on a change in pull request #1351: Shade pulsar-functions-runtime instead of pulsar-functions-worker

2018-03-06 Thread GitBox
sijie commented on a change in pull request #1351: Shade pulsar-functions-runtime instead of pulsar-functions-worker URL: https://github.com/apache/incubator-pulsar/pull/1351#discussion_r172705310 ## File path: pulsar-broker/pom.xml ## @@ -54,6 +54,18 @@ netty-all

[GitHub] merlimat closed pull request #1348: adding max retries for assignment write wait

2018-03-06 Thread GitBox
merlimat closed pull request #1348: adding max retries for assignment write wait URL: https://github.com/apache/incubator-pulsar/pull/1348 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[incubator-pulsar] branch master updated: adding max retries for assignment write wait (#1348)

2018-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e82ff7e adding max retries for assign

[GitHub] merlimat commented on a change in pull request #1351: Shade pulsar-functions-runtime instead of pulsar-functions-worker

2018-03-06 Thread GitBox
merlimat commented on a change in pull request #1351: Shade pulsar-functions-runtime instead of pulsar-functions-worker URL: https://github.com/apache/incubator-pulsar/pull/1351#discussion_r172701384 ## File path: pulsar-broker/pom.xml ## @@ -54,6 +54,18 @@ netty-al

[GitHub] sijie commented on issue #1351: Shade pulsar-functions-runtime instead of pulsar-functions-worker

2018-03-06 Thread GitBox
sijie commented on issue #1351: Shade pulsar-functions-runtime instead of pulsar-functions-worker URL: https://github.com/apache/incubator-pulsar/pull/1351#issuecomment-370972510 /cc @srkukarni @jerrypeng This is an automate

[GitHub] sijie opened a new pull request #1351: Shade pulsar-functions-runtime instead of pulsar-functions-worker

2018-03-06 Thread GitBox
sijie opened a new pull request #1351: Shade pulsar-functions-runtime instead of pulsar-functions-worker URL: https://github.com/apache/incubator-pulsar/pull/1351 ### Motivation `pulsar-functions-runtime` is required by worker/broker and also it would be packaged into a fat jar to u

[GitHub] merlimat commented on a change in pull request #1350: Pulsar Functions documentation (WIP)

2018-03-06 Thread GitBox
merlimat commented on a change in pull request #1350: Pulsar Functions documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1350#discussion_r172689851 ## File path: site/docs/latest/functions/guarantees.md ## @@ -0,0 +1,28 @@ +--- +title: Processing gua

[GitHub] merlimat commented on a change in pull request #1350: Pulsar Functions documentation (WIP)

2018-03-06 Thread GitBox
merlimat commented on a change in pull request #1350: Pulsar Functions documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1350#discussion_r172689899 ## File path: site/docs/latest/functions/guarantees.md ## @@ -0,0 +1,28 @@ +--- +title: Processing gua

[GitHub] lucperkins opened a new pull request #1350: Pulsar Functions documentation (WIP)

2018-03-06 Thread GitBox
lucperkins opened a new pull request #1350: Pulsar Functions documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1350 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] ivankelly commented on issue #1349: Base module for Arquillian integration tests

2018-03-06 Thread GitBox
ivankelly commented on issue #1349: Base module for Arquillian integration tests URL: https://github.com/apache/incubator-pulsar/pull/1349#issuecomment-370943611 @merlimat last one before I push the test itself. This is an aut

[GitHub] ivankelly opened a new pull request #1349: Base module for Arquillian integration tests

2018-03-06 Thread GitBox
ivankelly opened a new pull request #1349: Base module for Arquillian integration tests URL: https://github.com/apache/incubator-pulsar/pull/1349 Pulls in dependencies needed by all Arquillian integration tests, and configures surefire with enough memory. It also configures surefire t

[GitHub] jerrypeng commented on issue #1348: adding max retries for assignment write wait

2018-03-06 Thread GitBox
jerrypeng commented on issue #1348: adding max retries for assignment write wait URL: https://github.com/apache/incubator-pulsar/pull/1348#issuecomment-370936818 @merlimat @srkukarni @sijie This is an automated message from t

[GitHub] jerrypeng opened a new pull request #1348: adding max retries for assignment write wait

2018-03-06 Thread GitBox
jerrypeng opened a new pull request #1348: adding max retries for assignment write wait URL: https://github.com/apache/incubator-pulsar/pull/1348 Also fix issue with SchedulerAssignmentTest that may have been flaky since mockito is not necessarily thread safe -

[incubator-pulsar] branch master updated: Cleanup failed connection from background thread (#1345)

2018-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new da142eb Cleanup failed connection fro

[GitHub] merlimat closed pull request #1345: Cleanup failed connection from background thread

2018-03-06 Thread GitBox
merlimat closed pull request #1345: Cleanup failed connection from background thread URL: https://github.com/apache/incubator-pulsar/pull/1345 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] merlimat opened a new pull request #1347: Enforce timeout on all TestNG tests, thread dump on timeout

2018-03-06 Thread GitBox
merlimat opened a new pull request #1347: Enforce timeout on all TestNG tests, thread dump on timeout URL: https://github.com/apache/incubator-pulsar/pull/1347 ### Motivation * We have many tests which don't have a `timeOut=xxx` parameter on the `@Test` annotation * When a time

[GitHub] merlimat commented on issue #1345: Cleanup failed connection from background thread

2018-03-06 Thread GitBox
merlimat commented on issue #1345: Cleanup failed connection from background thread URL: https://github.com/apache/incubator-pulsar/pull/1345#issuecomment-370897736 retest this please This is an automated message from the Apa

[incubator-pulsar] branch master updated: Make it possible to get namespaces owned by broker when TLS is enabled (#1346)

2018-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2c5ef2d Make it possible to get names

[GitHub] merlimat closed pull request #1346: Make it possible to get namespaces owned by broker when TLS is enabled

2018-03-06 Thread GitBox
merlimat closed pull request #1346: Make it possible to get namespaces owned by broker when TLS is enabled URL: https://github.com/apache/incubator-pulsar/pull/1346 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] ivankelly commented on issue #1335: Log phases in two phase compaction

2018-03-06 Thread GitBox
ivankelly commented on issue #1335: Log phases in two phase compaction URL: https://github.com/apache/incubator-pulsar/pull/1335#issuecomment-370845951 retest this please This is an automated message from the Apache Git Servic

[GitHub] ivankelly commented on issue #1336: CompactedTopic should seek to position of cursor, not next position

2018-03-06 Thread GitBox
ivankelly commented on issue #1336: CompactedTopic should seek to position of cursor, not next position URL: https://github.com/apache/incubator-pulsar/pull/1336#issuecomment-370845844 Oops, merge seems to have broken something. Will look into it tomorrow --

[incubator-pulsar] branch asf-site updated: Updated site at revision a28c2cf

2018-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 7468d1d Updated site at revision

[incubator-pulsar] branch master updated: Arquillian topologies for integration testing (#1333)

2018-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a28c2cf Arquillian topologies for int

[GitHub] merlimat closed pull request #1333: Arquillian topologies for integration testing

2018-03-06 Thread GitBox
merlimat closed pull request #1333: Arquillian topologies for integration testing URL: https://github.com/apache/incubator-pulsar/pull/1333 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: Make default processing guarantee AT_LEAST_ONCE (#1340)

2018-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 350037a Make default processing guara

[GitHub] merlimat closed pull request #1340: Make default processing guarantee AT_LEAST_ONCE

2018-03-06 Thread GitBox
merlimat closed pull request #1340: Make default processing guarantee AT_LEAST_ONCE URL: https://github.com/apache/incubator-pulsar/pull/1340 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] merlimat closed pull request #1330: Added pulsar-1.22.0-incubating to site configuration

2018-03-06 Thread GitBox
merlimat closed pull request #1330: Added pulsar-1.22.0-incubating to site configuration URL: https://github.com/apache/incubator-pulsar/pull/1330 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: A

[incubator-pulsar] branch master updated: Added pulsar-1.22.0-incubating to site configuration (#1330)

2018-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 557166a Added pulsar-1.22.0-incubatin

[GitHub] massakam opened a new pull request #1346: Make it possible to get namespaces owned by broker when TLS is enabled

2018-03-06 Thread GitBox
massakam opened a new pull request #1346: Make it possible to get namespaces owned by broker when TLS is enabled URL: https://github.com/apache/incubator-pulsar/pull/1346 ### Motivation If TLS is enabled, `pulsar-admin brokers namespaces` command does not work properly. ```sh

[incubator-pulsar] branch asf-site updated: Updated site at revision e9e31c7

2018-03-06 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new c8dad2d Updated site at revision