zhaijack opened a new pull request #1359: Delete PartitionedConsumerImpl, use
TopicsConsumerImpl instead
URL: https://github.com/apache/incubator-pulsar/pull/1359
### Motivation
Currently we have both TopicsConsumerImpl and PartitionedConsumerImpl. The
behaviour and code of them are
jai1 commented on issue #1322: Use private impl for MessageId in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/1322#issuecomment-371403998
retest this please
This is an automated message from the Apache Git S
zhaijack commented on issue #1354: Issue 1118: refine handlerBase to let only
ConsumerImpl and ProducerImpl have client-cnx
URL: https://github.com/apache/incubator-pulsar/pull/1354#issuecomment-371340762
retest this please
T
zhaijack commented on issue #1354: Issue 1118: refine handlerBase to let only
ConsumerImpl and ProducerImpl have client-cnx
URL: https://github.com/apache/incubator-pulsar/pull/1354#issuecomment-371397512
retest this please
T
jai1 commented on a change in pull request #1322: Use private impl for
MessageId in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/1322#discussion_r173070365
##
File path: pulsar-client-cpp/lib/MessageIdImpl.h
##
@@ -0,0 +1,36 @@
+/**
+ * Licensed to the A
jai1 commented on issue #1322: Use private impl for MessageId in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/1322#issuecomment-371388067
retest this please
This is an automated message from the Apache Git S
yush1ga commented on issue #1352: Delete inactive subscriptions automatically
URL: https://github.com/apache/incubator-pulsar/pull/1352#issuecomment-371378494
retest this please
This is an automated message from the Apache Git
yush1ga commented on issue #1352: Delete inactive subscriptions automatically
URL: https://github.com/apache/incubator-pulsar/pull/1352#issuecomment-371378494
retest this please
This is an automated message from the Apache Git
zhaijack commented on issue #1354: Issue 1118: refine handlerBase to let only
ConsumerImpl and ProducerImpl have client-cnx
URL: https://github.com/apache/incubator-pulsar/pull/1354#issuecomment-371340762
retest this please
T
zhaijack opened a new pull request #1358: Issue 1071: add ratelimiter for
subscription
URL: https://github.com/apache/incubator-pulsar/pull/1358
### Motivation
Currently rate limiting and throttling are applied at namespace/topic level.
It would be good to provide a mechanism to app
srkukarni commented on a change in pull request #1357: Pulsar Functions
documentation follow-up
URL: https://github.com/apache/incubator-pulsar/pull/1357#discussion_r173002324
##
File path: site/docs/latest/functions/quickstart.md
##
@@ -1,29 +1,176 @@
---
title: Getting
srkukarni commented on a change in pull request #1357: Pulsar Functions
documentation follow-up
URL: https://github.com/apache/incubator-pulsar/pull/1357#discussion_r172999405
##
File path: site/docs/latest/functions/api.md
##
@@ -2,9 +2,70 @@
title: The Pulsar Functions
srkukarni commented on a change in pull request #1357: Pulsar Functions
documentation follow-up
URL: https://github.com/apache/incubator-pulsar/pull/1357#discussion_r172999261
##
File path: site/docs/latest/functions/api.md
##
@@ -2,9 +2,70 @@
title: The Pulsar Functions
mgodave commented on issue #1319: Schema registry (2/N)
URL: https://github.com/apache/incubator-pulsar/pull/1319#issuecomment-371300300
Ping
This is an automated message from the Apache Git Service.
To respond to the message,
lucperkins opened a new pull request #1357: Pulsar Functions documentation
follow-up
URL: https://github.com/apache/incubator-pulsar/pull/1357
This is an automated message from the Apache Git Service.
To respond to the messa
merlimat commented on issue #1322: Use private impl for MessageId in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/1322#issuecomment-371297087
@jai1 Addressed comments
This is an automated message from the Ap
merlimat commented on issue #1322: Use private impl for MessageId in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/1322#issuecomment-371296027
retest this please
This is an automated message from the Apache G
merlimat commented on issue #1322: Use private impl for MessageId in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/1322#issuecomment-371296027
retest this please
This is an automated message from the Apache G
sijie closed pull request #1356: Log Topic for Functions
URL: https://github.com/apache/incubator-pulsar/pull/1356
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 6b24ab9 Log Topic for Functions (#1356
mgodave closed pull request #1355: Remove as many Thread.sleep calls from REST
endpoint
URL: https://github.com/apache/incubator-pulsar/pull/1355
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
srkukarni commented on issue #1356: Log Topic for Functions
URL: https://github.com/apache/incubator-pulsar/pull/1356#issuecomment-371250939
@sijie @merlimat
This is an automated message from the Apache Git Service.
To respon
srkukarni opened a new pull request #1356: Log Topic for Functions
URL: https://github.com/apache/incubator-pulsar/pull/1356
### Motivation
Added ability to specify Log Topic where all logging done in a function go.
This is often times a very useful way to debug functions
mgodave commented on issue #1355: Remove as many Thread.sleep calls from REST
endpoint
URL: https://github.com/apache/incubator-pulsar/pull/1355#issuecomment-371242117
Feel free to close it.
On Mar 7, 2018 11:43, "Matteo Merli" wrote:
> The point is, sleeping a thread in the
merlimat commented on issue #1355: Remove as many Thread.sleep calls from REST
endpoint
URL: https://github.com/apache/incubator-pulsar/pull/1355#issuecomment-371240890
> The point is, sleeping a thread in the REST endpoint is a resource hog and
generally not a great idea.
I'm not
mgodave commented on issue #1355: Remove as many Thread.sleep calls from REST
endpoint
URL: https://github.com/apache/incubator-pulsar/pull/1355#issuecomment-371238796
I *think* I see what you are saying. Either way, scheduling a return after
the sync timeout would be a better option.
---
mgodave commented on issue #1355: Remove as many Thread.sleep calls from REST
endpoint
URL: https://github.com/apache/incubator-pulsar/pull/1355#issuecomment-371238039
The point is, sleeping a thread in the REST endpoint is a resource hog and
generally not a great idea.
--
merlimat commented on a change in pull request #1322: Use private impl for
MessageId in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/1322#discussion_r172939330
##
File path: pulsar-client-cpp/include/pulsar/MessageId.h
##
@@ -50,34 +47,44 @@ class Messag
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new dad679a CompactedTopic should seek to
merlimat closed pull request #1336: CompactedTopic should seek to position of
cursor, not next position
URL: https://github.com/apache/incubator-pulsar/pull/1336
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
merlimat commented on a change in pull request #1322: Use private impl for
MessageId in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/1322#discussion_r172937375
##
File path: pulsar-client-cpp/lib/MessageId.cc
##
@@ -30,43 +29,51 @@
namespace pulsar {
merlimat commented on issue #1355: Remove as many Thread.sleep calls from REST
endpoint
URL: https://github.com/apache/incubator-pulsar/pull/1355#issuecomment-371232050
@mgodave This change doesn't solve the problem that the ugly
`Thread.sleep()` was introduced as a workaround for.
merlimat commented on a change in pull request #1322: Use private impl for
MessageId in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/1322#discussion_r172932307
##
File path: pulsar-client-cpp/lib/MessageId.cc
##
@@ -30,43 +29,51 @@
namespace pulsar {
mgodave opened a new pull request #1355: Remove as many Thread.sleep calls from
REST endpoint
URL: https://github.com/apache/incubator-pulsar/pull/1355
Thread.sleep is rarely the correct answer as it can lead to race conditions
and incorrect results. In this case sleeping the tread will ti
ivankelly commented on issue #1145: Intermittent test failure in
PersistentTopicTest.testClosingReplicationProducerTwice
URL:
https://github.com/apache/incubator-pulsar/issues/1145#issuecomment-371220837
Found the race. The builder stuff messed up this test completely, but the
race is sti
ivankelly commented on issue #1145: Intermittent test failure in
PersistentTopicTest.testClosingReplicationProducerTwice
URL:
https://github.com/apache/incubator-pulsar/issues/1145#issuecomment-371209316
There any logs beside that snippet?
maskit commented on issue #1266: Pass all Apache Podling Website Checks
URL:
https://github.com/apache/incubator-pulsar/issues/1266#issuecomment-371205912
Generated a 212px width PNG logo image from the SVG in site/img/ that
satisfies the requirement[1].
![pulsar](https://user-imag
zhaijack opened a new pull request #1354: Issue 1118: refine handlerBase to let
only ConsumerImpl and ProducerImpl have client-cnx
URL: https://github.com/apache/incubator-pulsar/pull/1354
### Motivation
class HandlerBase contains 2 parts:
- handler state; this is need for all h
ivankelly commented on issue #1145: Intermittent test failure in
PersistentTopicTest.testClosingReplicationProducerTwice
URL:
https://github.com/apache/incubator-pulsar/issues/1145#issuecomment-371188779
This is a dupe of #617
-
maskit commented on issue #1258: Fix CID 262329
URL: https://github.com/apache/incubator-pulsar/pull/1258#issuecomment-371185764
retest this please
This is an automated message from the Apache Git Service.
To respond to the me
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new a8a595d Have the ability to send log
merlimat closed pull request #1353: Have the ability to send log messages to a
topic in Python
URL: https://github.com/apache/incubator-pulsar/pull/1353
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenan
XiaoZYang commented on issue #1219: Issue 1069: Provide a setting in consumer
configuration to specify where to start consuming messages
URL: https://github.com/apache/incubator-pulsar/pull/1219#issuecomment-371149305
ping @merlimat
Thanks for making a review on this commit.
Since t
XiaoZYang commented on issue #1219: Issue 1069: Provide a setting in consumer
configuration to specify where to start consuming messages
URL: https://github.com/apache/incubator-pulsar/pull/1219#issuecomment-371149305
ping @merlimat
Since the earliest position should be the first messa
zhaijack closed issue #1237: Make subscribe for TopicsConsumer using builder
URL: https://github.com/apache/incubator-pulsar/issues/1237
This is an automated message from the Apache Git Service.
To respond to the message, ple
yush1ga commented on a change in pull request #1352: Delete inactive
subscriptions automatically
URL: https://github.com/apache/incubator-pulsar/pull/1352#discussion_r172765485
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##
yush1ga commented on issue #1352: Delete inactive subscriptions automatically
URL: https://github.com/apache/incubator-pulsar/pull/1352#issuecomment-371057712
@merlimat
> Another question is: how can this be enforced across brokers restarts?
Did you mean that a scheduler for inact
47 matches
Mail list logo