[incubator-pulsar] branch master updated: Fix java docs (#1389)

2018-03-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e118a22 Fix java docs (#1389) e118a22

[GitHub] merlimat closed pull request #1389: Fix Reader.readNext() java docs

2018-03-14 Thread GitBox
merlimat closed pull request #1389: Fix Reader.readNext() java docs URL: https://github.com/apache/incubator-pulsar/pull/1389 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] srkukarni commented on issue #1389: Fix java docs

2018-03-14 Thread GitBox
srkukarni commented on issue #1389: Fix java docs URL: https://github.com/apache/incubator-pulsar/pull/1389#issuecomment-373250501 @merlimat @lucperkins This is an automated message from the Apache Git Service. To respond to

[GitHub] srkukarni opened a new pull request #1389: Fix java docs

2018-03-14 Thread GitBox
srkukarni opened a new pull request #1389: Fix java docs URL: https://github.com/apache/incubator-pulsar/pull/1389 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve. ### Modifications Describe the mo

[incubator-pulsar] branch master updated: remove function package on function delete (#1385)

2018-03-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5c31b2e remove function package on fu

[GitHub] merlimat closed pull request #1385: remove function package on function delete

2018-03-14 Thread GitBox
merlimat closed pull request #1385: remove function package on function delete URL: https://github.com/apache/incubator-pulsar/pull/1385 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat commented on issue #1384: Prepare admin client to support v2 api.

2018-03-14 Thread GitBox
merlimat commented on issue #1384: Prepare admin client to support v2 api. URL: https://github.com/apache/incubator-pulsar/pull/1384#issuecomment-373250314 retest this please This is an automated message from the Apache Git Se

[GitHub] merlimat opened a new issue #1388: Intermittent test failures in BrokerBkEnsemblesTests.testSkipCorruptDataLedger()

2018-03-14 Thread GitBox
merlimat opened a new issue #1388: Intermittent test failures in BrokerBkEnsemblesTests.testSkipCorruptDataLedger() URL: https://github.com/apache/incubator-pulsar/issues/1388 https://builds.apache.org/job/pulsar-pull-request/org.apache.pulsar$pulsar-broker/2119/testReport/junit/org.apache

[GitHub] sijie commented on issue #1386: Improve sync send logic for allowing turning batching as default produce behavior

2018-03-14 Thread GitBox
sijie commented on issue #1386: Improve sync send logic for allowing turning batching as default produce behavior URL: https://github.com/apache/incubator-pulsar/pull/1386#issuecomment-373233133 > As a separate task we should now enable batching by default. after #1387, I will flip t

[GitHub] sijie opened a new pull request #1387: Build batching-awareness into round-robin message router

2018-03-14 Thread GitBox
sijie opened a new pull request #1387: Build batching-awareness into round-robin message router URL: https://github.com/apache/incubator-pulsar/pull/1387 ### Motivation The default `SinglePartition` message router works well when you have more producers than the number of pa

[GitHub] merlimat commented on issue #1384: Prepare admin client to support v2 api.

2018-03-14 Thread GitBox
merlimat commented on issue #1384: Prepare admin client to support v2 api. URL: https://github.com/apache/incubator-pulsar/pull/1384#issuecomment-373223156 retest this please This is an automated message from the Apache Git Se

[GitHub] merlimat commented on issue #1384: Prepare admin client to support v2 api.

2018-03-14 Thread GitBox
merlimat commented on issue #1384: Prepare admin client to support v2 api. URL: https://github.com/apache/incubator-pulsar/pull/1384#issuecomment-373223156 retest this please This is an automated message from the Apache Git Se

[GitHub] merlimat commented on issue #1379: Fixed BK PrometheusProvider package name

2018-03-14 Thread GitBox
merlimat commented on issue #1379: Fixed BK PrometheusProvider package name URL: https://github.com/apache/incubator-pulsar/pull/1379#issuecomment-373221468 retest this please This is an automated message from the Apache Git S

[GitHub] merlimat commented on issue #1379: Fixed BK PrometheusProvider package name

2018-03-14 Thread GitBox
merlimat commented on issue #1379: Fixed BK PrometheusProvider package name URL: https://github.com/apache/incubator-pulsar/pull/1379#issuecomment-373221468 retest this please This is an automated message from the Apache Git S

[GitHub] merlimat commented on issue #1379: Fixed BK PrometheusProvider package name

2018-03-14 Thread GitBox
merlimat commented on issue #1379: Fixed BK PrometheusProvider package name URL: https://github.com/apache/incubator-pulsar/pull/1379#issuecomment-372879154 retest this please This is an automated message from the Apache Git S

[GitHub] sijie opened a new pull request #1386: Improve sync send logic for allowing batching

2018-03-14 Thread GitBox
sijie opened a new pull request #1386: Improve sync send logic for allowing batching URL: https://github.com/apache/incubator-pulsar/pull/1386 ### Motivation Batching is required for achieving high performance messaging. If we want to flip the default behaviour of publishers into ba

[GitHub] jerrypeng commented on issue #1385: remove function package on function delete

2018-03-14 Thread GitBox
jerrypeng commented on issue #1385: remove function package on function delete URL: https://github.com/apache/incubator-pulsar/pull/1385#issuecomment-373205047 @sijie @srkukarni thanks for the review. I have addressed your comments --

[GitHub] srkukarni commented on issue #1378: Standardize on input/output terminology for Pulsar Functions

2018-03-14 Thread GitBox
srkukarni commented on issue #1378: Standardize on input/output terminology for Pulsar Functions URL: https://github.com/apache/incubator-pulsar/pull/1378#issuecomment-373203280 retest this please This is an automated message

[GitHub] srkukarni commented on a change in pull request #1385: remove function package on function delete

2018-03-14 Thread GitBox
srkukarni commented on a change in pull request #1385: remove function package on function delete URL: https://github.com/apache/incubator-pulsar/pull/1385#discussion_r174635439 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionActioner.

[GitHub] sijie commented on a change in pull request #1385: remove function package on function delete

2018-03-14 Thread GitBox
sijie commented on a change in pull request #1385: remove function package on function delete URL: https://github.com/apache/incubator-pulsar/pull/1385#discussion_r174629326 ## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Utils.java #

[GitHub] jerrypeng opened a new pull request #1385: remove function package on function delete

2018-03-14 Thread GitBox
jerrypeng opened a new pull request #1385: remove function package on function delete URL: https://github.com/apache/incubator-pulsar/pull/1385 @sijie @srkukarni can you please review This is an automated message from the Apa

[incubator-pulsar] branch master updated: Add compactedOut flag for batched messages (#1361)

2018-03-14 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e0c9e7a Add compactedOut flag for batc

[GitHub] sijie closed pull request #1361: Add compactedOut flag for batched messages

2018-03-14 Thread GitBox
sijie closed pull request #1361: Add compactedOut flag for batched messages URL: https://github.com/apache/incubator-pulsar/pull/1361 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[GitHub] cckellogg opened a new pull request #1384: Prepare admin client to support v2 api.

2018-03-14 Thread GitBox
cckellogg opened a new pull request #1384: Prepare admin client to support v2 api. URL: https://github.com/apache/incubator-pulsar/pull/1384 Prepare the admin client so it can support the v2 admin rest endpoints. This is

[GitHub] jerrypeng commented on issue #1373: Functions metrics prometheus

2018-03-14 Thread GitBox
jerrypeng commented on issue #1373: Functions metrics prometheus URL: https://github.com/apache/incubator-pulsar/pull/1373#issuecomment-373157111 @merlimat thanks for the review. I have added a unit test This is an automated

[GitHub] cckellogg opened a new issue #1383: Unable to delete partitioned metadata for a partitioned topic

2018-03-14 Thread GitBox
cckellogg opened a new issue #1383: Unable to delete partitioned metadata for a partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1383 Unable to delete the metadata for a partitioned topic if no messages are produced on that topic. Repo steps: 1 - creat

[GitHub] srkukarni commented on a change in pull request #1382: Correlate Output of function with input

2018-03-14 Thread GitBox
srkukarni commented on a change in pull request #1382: Correlate Output of function with input URL: https://github.com/apache/incubator-pulsar/pull/1382#discussion_r174568620 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunn

[GitHub] merlimat commented on a change in pull request #1382: Correlate Output of function with input

2018-03-14 Thread GitBox
merlimat commented on a change in pull request #1382: Correlate Output of function with input URL: https://github.com/apache/incubator-pulsar/pull/1382#discussion_r174567157 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunna

[GitHub] merlimat commented on a change in pull request #1382: Correlate Output of function with input

2018-03-14 Thread GitBox
merlimat commented on a change in pull request #1382: Correlate Output of function with input URL: https://github.com/apache/incubator-pulsar/pull/1382#discussion_r174567157 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunna

[GitHub] srkukarni commented on issue #1382: Correlate Output of function with input

2018-03-14 Thread GitBox
srkukarni commented on issue #1382: Correlate Output of function with input URL: https://github.com/apache/incubator-pulsar/pull/1382#issuecomment-373119592 @sijie @merlimat This is an automated message from the Apache Git Se

[GitHub] srkukarni opened a new pull request #1382: Correlate Output of function with input

2018-03-14 Thread GitBox
srkukarni opened a new pull request #1382: Correlate Output of function with input URL: https://github.com/apache/incubator-pulsar/pull/1382 ### Motivation Attach information about which input topic/msgid triggered the function computation in any output ### Modificati

[GitHub] mgodave commented on issue #1381: Schema registry 4/N

2018-03-14 Thread GitBox
mgodave commented on issue #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#issuecomment-373115018 Hold on, I've made a lot of these changes but I think my last two branches have misplaced commits. I might just merge them into one last pr. On Wed

[GitHub] merlimat commented on a change in pull request #1381: Schema registry 4/N

2018-03-14 Thread GitBox
merlimat commented on a change in pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#discussion_r174546254 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] merlimat commented on a change in pull request #1381: Schema registry 4/N

2018-03-14 Thread GitBox
merlimat commented on a change in pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#discussion_r174546852 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] merlimat commented on a change in pull request #1381: Schema registry 4/N

2018-03-14 Thread GitBox
merlimat commented on a change in pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#discussion_r174545638 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] merlimat commented on a change in pull request #1381: Schema registry 4/N

2018-03-14 Thread GitBox
merlimat commented on a change in pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#discussion_r174546539 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/SchemasResource.java ## @@ -0,0 +1,273 @@ +/**

[GitHub] mgodave opened a new pull request #1381: Schema registry 4/N

2018-03-14 Thread GitBox
mgodave opened a new pull request #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381 See #1137 for reference This is an automated message from the Apache Git Service. To respond to the message

[GitHub] zhaijack commented on issue #1358: Issue 1071: add ratelimiter for subscription

2018-03-14 Thread GitBox
zhaijack commented on issue #1358: Issue 1071: add ratelimiter for subscription URL: https://github.com/apache/incubator-pulsar/pull/1358#issuecomment-373020578 retest this please This is an automated message from the Apache G

[GitHub] ivankelly commented on issue #1361: Add compactedOut flag for batched messages

2018-03-14 Thread GitBox
ivankelly commented on issue #1361: Add compactedOut flag for batched messages URL: https://github.com/apache/incubator-pulsar/pull/1361#issuecomment-372961444 @merlimat Exactly. Unpooled.EMPTY_BUFFER is what I'm using. This i

[GitHub] zhaijack commented on issue #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages

2018-03-14 Thread GitBox
zhaijack commented on issue #1219: Issue 1069: Provide a setting in consumer configuration to specify where to start consuming messages URL: https://github.com/apache/incubator-pulsar/pull/1219#issuecomment-372955476 Oh, @XiaoZYang Seems your rebase brings in too much un-related commits an