[GitHub] zhaijack commented on issue #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

2018-06-08 Thread GitBox
zhaijack commented on issue #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#issuecomment-395266577 retest this please This is an

[GitHub] zhaijack commented on issue #1858: Cpp client: add readCompacted in consumer config

2018-06-08 Thread GitBox
zhaijack commented on issue #1858: Cpp client: add readCompacted in consumer config URL: https://github.com/apache/incubator-pulsar/pull/1858#issuecomment-395927722 retest this please This is an automated message from the Apa

[GitHub] rdhabalia commented on issue #1946: Use broker advertisedAddress + tls url in function worker

2018-06-08 Thread GitBox
rdhabalia commented on issue #1946: Use broker advertisedAddress + tls url in function worker URL: https://github.com/apache/incubator-pulsar/pull/1946#issuecomment-395926154 @massakam as we discussed on #1935 This is an aut

[incubator-pulsar] branch master updated: Fix: managedledger factory shutdown stuck when any of ledger future-result is not completed (#1945)

2018-06-08 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8682776 Fix: managedledger factory

[GitHub] rdhabalia closed pull request #1946: Use broker advertisedAddress + tls url in function worker

2018-06-08 Thread GitBox
rdhabalia closed pull request #1946: Use broker advertisedAddress + tls url in function worker URL: https://github.com/apache/incubator-pulsar/pull/1946 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[incubator-pulsar] branch master updated: Use broker advertisedAddress + tls url in function worker (#1946)

2018-06-08 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 2bf387d Use broker advertisedAddre

[GitHub] rdhabalia closed pull request #1945: Fix: managedledger factory shutdown stuck when any of ledger future-result is not completed

2018-06-08 Thread GitBox
rdhabalia closed pull request #1945: Fix: managedledger factory shutdown stuck when any of ledger future-result is not completed URL: https://github.com/apache/incubator-pulsar/pull/1945 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displ

[GitHub] jerrypeng commented on a change in pull request #1917: adding avro schema

2018-06-08 Thread GitBox
jerrypeng commented on a change in pull request #1917: adding avro schema URL: https://github.com/apache/incubator-pulsar/pull/1917#discussion_r194204481 ## File path: pulsar-client-shaded/pom.xml ## @@ -86,6 +86,14 @@ org.apache.httpcomponents:httpclien

[GitHub] merlimat commented on a change in pull request #1917: adding avro schema

2018-06-08 Thread GitBox
merlimat commented on a change in pull request #1917: adding avro schema URL: https://github.com/apache/incubator-pulsar/pull/1917#discussion_r194203236 ## File path: pulsar-client-shaded/pom.xml ## @@ -86,6 +86,14 @@ org.apache.httpcomponents:httpclient

[GitHub] jerrypeng commented on issue #1917: adding avro schema

2018-06-08 Thread GitBox
jerrypeng commented on issue #1917: adding avro schema URL: https://github.com/apache/incubator-pulsar/pull/1917#issuecomment-395919037 @merlimat I have shaded the avro dependences. Please check if I got them all This is an a

[incubator-pulsar] branch master updated: Have the ability to specify instance id offset in localrun (#1938)

2018-06-08 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 51a7c02 Have the ability to specif

[GitHub] srkukarni closed pull request #1938: Have the ability to specify instance id offset in localrun

2018-06-08 Thread GitBox
srkukarni closed pull request #1938: Have the ability to specify instance id offset in localrun URL: https://github.com/apache/incubator-pulsar/pull/1938 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[GitHub] srkukarni commented on a change in pull request #1941: Tiered Storage documentation

2018-06-08 Thread GitBox
srkukarni commented on a change in pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#discussion_r194192059 ## File path: site/docs/latest/cookbooks/tiered-storage.md ## @@ -0,0 +1,119 @@ +--- +title: Tiered Storage +

[GitHub] srkukarni commented on a change in pull request #1941: Tiered Storage documentation

2018-06-08 Thread GitBox
srkukarni commented on a change in pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#discussion_r194191756 ## File path: site/docs/latest/cookbooks/tiered-storage.md ## @@ -0,0 +1,119 @@ +--- +title: Tiered Storage +

[GitHub] srkukarni commented on a change in pull request #1941: Tiered Storage documentation

2018-06-08 Thread GitBox
srkukarni commented on a change in pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#discussion_r194191655 ## File path: site/docs/latest/cookbooks/tiered-storage.md ## @@ -0,0 +1,119 @@ +--- +title: Tiered Storage +

[GitHub] merlimat commented on a change in pull request #1944: Add CLI commands for schema registry

2018-06-08 Thread GitBox
merlimat commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r194191607 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java ## @@ -0,

[GitHub] srkukarni commented on a change in pull request #1944: Add CLI commands for schema registry

2018-06-08 Thread GitBox
srkukarni commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r194191179 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java ## @@ -0

[GitHub] srkukarni commented on a change in pull request #1944: Add CLI commands for schema registry

2018-06-08 Thread GitBox
srkukarni commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r194191137 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSchemas.java ## @@ -0

[GitHub] srkukarni commented on a change in pull request #1944: Add CLI commands for schema registry

2018-06-08 Thread GitBox
srkukarni commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r194190912 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/SchemasImpl.java

[incubator-pulsar] branch master updated: Instructions to build site on linux without root (#1939)

2018-06-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7a86673 Instructions to build site on

[GitHub] merlimat closed pull request #1939: Instructions to build site on linux without root

2018-06-08 Thread GitBox
merlimat closed pull request #1939: Instructions to build site on linux without root URL: https://github.com/apache/incubator-pulsar/pull/1939 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] sijie commented on issue #1940: Fix reference configuration display

2018-06-08 Thread GitBox
sijie commented on issue #1940: Fix reference configuration display URL: https://github.com/apache/incubator-pulsar/pull/1940#issuecomment-395891569 retest this please This is an automated message from the Apache Git Service.

[GitHub] sijie commented on issue #1941: Tiered Storage documentation

2018-06-08 Thread GitBox
sijie commented on issue #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#issuecomment-395891279 @aahmed-se @mgodave @srkukarni can you guys help review documentation? This is an au

[GitHub] sijie commented on issue #1944: Add CLI commands for schema registry

2018-06-08 Thread GitBox
sijie commented on issue #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#issuecomment-395890879 @jerrypeng @srkukarni please help review this This is an automated message f

[GitHub] sijie commented on a change in pull request #1944: Add CLI commands for schema registry

2018-06-08 Thread GitBox
sijie commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r194181707 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Schemas.java ## @@ -0,0 +

[GitHub] rdhabalia opened a new pull request #1946: Use broker advertisedAddress + tls url in function worker

2018-06-08 Thread GitBox
rdhabalia opened a new pull request #1946: Use broker advertisedAddress + tls url in function worker URL: https://github.com/apache/incubator-pulsar/pull/1946 ### Motivation Function can use broker's advertised-address and tls url if function and broker supports it. ### Modif

[GitHub] rdhabalia opened a new pull request #1945: Fix: managedledger factory shutdown stuck when any of ledger future-result is not completed

2018-06-08 Thread GitBox
rdhabalia opened a new pull request #1945: Fix: managedledger factory shutdown stuck when any of ledger future-result is not completed URL: https://github.com/apache/incubator-pulsar/pull/1945 ### Motivation While closing ManagedLedgerFactory, if one of the ledger-future is not com

[GitHub] mgodave opened a new pull request #1944: Add CLI commands for schema registry

2018-06-08 Thread GitBox
mgodave opened a new pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944 This is an automated message from the Apache Git Service. To respond to the message, plea

[incubator-pulsar] branch master updated: Add Client auth plugin and tls support for function to connect with broker (#1935)

2018-06-08 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6e336b4 Add Client auth plugin and

[GitHub] rdhabalia closed pull request #1935: Add Client auth plugin and tls support for function to connect with broker

2018-06-08 Thread GitBox
rdhabalia closed pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] rdhabalia commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

2018-06-08 Thread GitBox
rdhabalia commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r194164704 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarBroker

[GitHub] srkukarni commented on issue #1938: Have the ability to specify instance id offset in localrun

2018-06-08 Thread GitBox
srkukarni commented on issue #1938: Have the ability to specify instance id offset in localrun URL: https://github.com/apache/incubator-pulsar/pull/1938#issuecomment-395867214 retest this please This is an automated message f

[GitHub] srkukarni commented on issue #1938: Have the ability to specify instance id offset in localrun

2018-06-08 Thread GitBox
srkukarni commented on issue #1938: Have the ability to specify instance id offset in localrun URL: https://github.com/apache/incubator-pulsar/pull/1938#issuecomment-395844992 retest this please This is an automated message f

[GitHub] sijie commented on issue #1943: Non serializable client builder

2018-06-08 Thread GitBox
sijie commented on issue #1943: Non serializable client builder URL: https://github.com/apache/incubator-pulsar/issues/1943#issuecomment-395832694 Can we do things like `PulsarClient.builder.withConf(ClientConfiguration).build()`? --

[GitHub] merlimat commented on issue #1943: Non serializable client builder

2018-06-08 Thread GitBox
merlimat commented on issue #1943: Non serializable client builder URL: https://github.com/apache/incubator-pulsar/issues/1943#issuecomment-395820413 The problem has not an easy fix. The builders impl intrinsically hold references to non-serializable objects (eg: Client instance, or auth

[GitHub] merlimat commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

2018-06-08 Thread GitBox
merlimat commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194116244 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ## @

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

2018-06-08 Thread GitBox
ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194109234 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

2018-06-08 Thread GitBox
ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194108728 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

2018-06-08 Thread GitBox
ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194107081 ## File path: pulsar-client-cpp/lib/ConsumerImpl.h ## @@ -1

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

2018-06-08 Thread GitBox
ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194104557 ## File path: pulsar-client-cpp/lib/ConsumerImpl.h ## @@ -1

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

2018-06-08 Thread GitBox
ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194101542 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ##

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

2018-06-08 Thread GitBox
ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194100685 ## File path: pulsar-client-cpp/lib/ClientConnection.cc ##

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

2018-06-08 Thread GitBox
ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194108495 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

2018-06-08 Thread GitBox
ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194106349 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -

[GitHub] ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader

2018-06-08 Thread GitBox
ivankelly commented on a change in pull request #1861: Cpp client: add getLastMessageId and hasMessageAvailable in consmer and reader URL: https://github.com/apache/incubator-pulsar/pull/1861#discussion_r194107442 ## File path: pulsar-client-cpp/lib/ConsumerImpl.cc ## @@ -

[incubator-pulsar] branch master updated: Added a bunch of concrete sources/sinks so that they are usable without having to write code (#1934)

2018-06-08 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1950538 Added a bunch of concrete sour

[GitHub] sijie closed pull request #1934: Added a bunch of concrete sources/sinks so that they are usable without having to write code

2018-06-08 Thread GitBox
sijie closed pull request #1934: Added a bunch of concrete sources/sinks so that they are usable without having to write code URL: https://github.com/apache/incubator-pulsar/pull/1934 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] sijie closed pull request #1936: Cpp client: fix flaky seek test

2018-06-08 Thread GitBox
sijie closed pull request #1936: Cpp client: fix flaky seek test URL: https://github.com/apache/incubator-pulsar/pull/1936 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Cpp client: fix flaky seek test (#1936)

2018-06-08 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new bff4f8b Cpp client: fix flaky seek tes

[GitHub] sijie commented on issue #1942: Fix topic name in getting started documentation

2018-06-08 Thread GitBox
sijie commented on issue #1942: Fix topic name in getting started documentation URL: https://github.com/apache/incubator-pulsar/pull/1942#issuecomment-395804081 shall put a link on the 2.0 documents to refer back to 1.22.x release doc if people are using 1.22.x clients? just like what we di

[incubator-pulsar] branch master updated: Fix doc build error on broker config (#1937)

2018-06-08 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new c2e9219 Fix doc build error on broker

[GitHub] sijie closed pull request #1937: Fix doc build error on broker config

2018-06-08 Thread GitBox
sijie closed pull request #1937: Fix doc build error on broker config URL: https://github.com/apache/incubator-pulsar/pull/1937 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] sijie opened a new issue #1943: Non serializable client builder

2018-06-08 Thread GitBox
sijie opened a new issue #1943: Non serializable client builder URL: https://github.com/apache/incubator-pulsar/issues/1943 ``` One of the main change concerns the configuration classes, replace by builders. Although ProducerBuilder and ConsumerBuilder interfaces implement Seriali

[GitHub] ivankelly commented on issue #1942: Fix topic name in getting started documentation

2018-06-08 Thread GitBox
ivankelly commented on issue #1942: Fix topic name in getting started documentation URL: https://github.com/apache/incubator-pulsar/pull/1942#issuecomment-395796980 ah, it was an old version of the client. Still confusing for them though. ---

[GitHub] ivankelly commented on issue #1942: Fix topic name in getting started documentation

2018-06-08 Thread GitBox
ivankelly commented on issue #1942: Fix topic name in getting started documentation URL: https://github.com/apache/incubator-pulsar/pull/1942#issuecomment-395796456 @merlimat there was a user complaining that it wasn't working recently on slack

[GitHub] ivankelly opened a new pull request #1942: Fix topic name in getting started documentation

2018-06-08 Thread GitBox
ivankelly opened a new pull request #1942: Fix topic name in getting started documentation URL: https://github.com/apache/incubator-pulsar/pull/1942 It was "my-topic", when it should have been persistent://public/default/my-topic.

[GitHub] ivankelly opened a new pull request #1941: Tiered Storage documentation

2018-06-08 Thread GitBox
ivankelly opened a new pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941 The patch adds a section in "Concepts and Architecture" and a cookbook for setting up tiered storage with S3. Master Issue: #1511 -

[GitHub] ivankelly commented on issue #1940: Fix reference configuration display

2018-06-08 Thread GitBox
ivankelly commented on issue #1940: Fix reference configuration display URL: https://github.com/apache/incubator-pulsar/pull/1940#issuecomment-395793758 Before: ![image](https://user-images.githubusercontent.com/54955/41166107-b1d64f70-6b3f-11e8-8939-1801a9ca514d.png) After:

[GitHub] ivankelly opened a new pull request #1940: Fix reference configuration display

2018-06-08 Thread GitBox
ivankelly opened a new pull request #1940: Fix reference configuration display URL: https://github.com/apache/incubator-pulsar/pull/1940 Long lines were not wrapping, so they were overflowing on the next cell. Maybe not a problem if you have a gigantic monitor, but a lot of people do n

[GitHub] ivankelly commented on issue #1939: Instructions to build site on linux with root

2018-06-08 Thread GitBox
ivankelly commented on issue #1939: Instructions to build site on linux with root URL: https://github.com/apache/incubator-pulsar/pull/1939#issuecomment-395793170 Site won't actually build until is in https://github.com/apache/incubator-pulsar/pull/1937 Would be good if someone coul

[GitHub] ivankelly opened a new pull request #1939: Instructions to build site on linux with root

2018-06-08 Thread GitBox
ivankelly opened a new pull request #1939: Instructions to build site on linux with root URL: https://github.com/apache/incubator-pulsar/pull/1939 Previously you required root access in linux to build a bunch of html files. This patch makes it so you no longer need root to run the act

[GitHub] srkukarni opened a new pull request #1938: Have the ability to specify instance id offset in localrun

2018-06-08 Thread GitBox
srkukarni opened a new pull request #1938: Have the ability to specify instance id offset in localrun URL: https://github.com/apache/incubator-pulsar/pull/1938 ### Motivation To run functions in kubernetes, the most easiest approach would be to launch the k8 containers running funct

[GitHub] zhaijack commented on issue #1858: Cpp client: add readCompacted in consumer config

2018-06-08 Thread GitBox
zhaijack commented on issue #1858: Cpp client: add readCompacted in consumer config URL: https://github.com/apache/incubator-pulsar/pull/1858#issuecomment-395626566 retest this please This is an automated message from the Apa

[GitHub] zhaijack commented on issue #1858: Cpp client: add readCompacted in consumer config

2018-06-08 Thread GitBox
zhaijack commented on issue #1858: Cpp client: add readCompacted in consumer config URL: https://github.com/apache/incubator-pulsar/pull/1858#issuecomment-395764038 PR #1936 is for the cpp seek flaky test fix This is an autom

[GitHub] nkurihar commented on a change in pull request #1907: Added documentation for authn & authz plugins

2018-06-08 Thread GitBox
nkurihar commented on a change in pull request #1907: Added documentation for authn & authz plugins URL: https://github.com/apache/incubator-pulsar/pull/1907#discussion_r194040422 ## File path: site/docs/latest/reference/CustomAuth.md ## @@ -0,0 +1,228 @@ +--- +title: Exte

[GitHub] nkurihar commented on a change in pull request #1922: Enable bookkeeper table service in pulsar standalone

2018-06-08 Thread GitBox
nkurihar commented on a change in pull request #1922: Enable bookkeeper table service in pulsar standalone URL: https://github.com/apache/incubator-pulsar/pull/1922#discussion_r194035940 ## File path: pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/LocalBookkeeperE

[GitHub] ivankelly opened a new pull request #1937: Fix doc build error on broker config

2018-06-08 Thread GitBox
ivankelly opened a new pull request #1937: Fix doc build error on broker config URL: https://github.com/apache/incubator-pulsar/pull/1937 A recent change added a description with a : to the config data. This broke the yaml parser. Solution is to quote the string in question. -

[GitHub] massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

2018-06-08 Thread GitBox
massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r194002698 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerS

[GitHub] massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

2018-06-08 Thread GitBox
massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r194002521 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerS

[GitHub] massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

2018-06-08 Thread GitBox
massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r194002521 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerS

[GitHub] massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

2018-06-08 Thread GitBox
massakam commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r194001198 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerS

[GitHub] zhaijack opened a new pull request #1936: Cpp client: fix flaky seek test

2018-06-08 Thread GitBox
zhaijack opened a new pull request #1936: Cpp client: fix flaky seek test URL: https://github.com/apache/incubator-pulsar/pull/1936 In BasicEndToEndTest, test case `TEST(BasicEndToEndTest, testSeek)` is flaky because of not wait enough time for consumer connection. This PR add sleep time

[GitHub] rdhabalia commented on issue #1935: Add Client auth plugin and tls support for function to connect with broker

2018-06-08 Thread GitBox
rdhabalia commented on issue #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#issuecomment-395693775 retest this please This is an aut

[GitHub] rdhabalia commented on issue #1935: Add Client auth plugin and tls support for function to connect with broker

2018-06-08 Thread GitBox
rdhabalia commented on issue #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#issuecomment-395693775 retest this please This is an aut

[GitHub] hrsakai commented on a change in pull request #1838: Pulsar Go client docs

2018-06-08 Thread GitBox
hrsakai commented on a change in pull request #1838: Pulsar Go client docs URL: https://github.com/apache/incubator-pulsar/pull/1838#discussion_r193988604 ## File path: site/docs/latest/clients/go.md ## @@ -0,0 +1,589 @@ +--- +title: The Pulsar Go client +tags: [client, go,

[GitHub] hrsakai commented on a change in pull request #1838: Pulsar Go client docs

2018-06-08 Thread GitBox
hrsakai commented on a change in pull request #1838: Pulsar Go client docs URL: https://github.com/apache/incubator-pulsar/pull/1838#discussion_r193984538 ## File path: site/docs/latest/clients/go.md ## @@ -0,0 +1,589 @@ +--- +title: The Pulsar Go client +tags: [client, go,

[GitHub] rdhabalia commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker

2018-06-08 Thread GitBox
rdhabalia commented on a change in pull request #1935: Add Client auth plugin and tls support for function to connect with broker URL: https://github.com/apache/incubator-pulsar/pull/1935#discussion_r193975538 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/f